linux-kernel - Re: [PATCH v3 2/3] media: i2c: Add GT97xx VCM driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZnW6BO0ZLPPI71TP@kekkonen.localdomain>
Date: Fri, 21 Jun 2024 17:36:04 +0000
From: "sakari.ailus@...ux.intel.com" <sakari.ailus@...ux.intel.com>
To: Andy Shevchenko <andy.shevchenko@...il.com>
Cc: Kieran Bingham <kieran.bingham@...asonboard.com>,
	Zhi Mao 毛智 <zhi.mao@...iatek.com>,
	angelogioacchino.delregno@...labora.com, conor+dt@...nel.org,
	krzk+dt@...nel.org, mchehab@...nel.org, robh@...nel.org,
	dongchun.zhu@...iatek.com, "heiko@...ech.de" <heiko@...ech.de>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"laurent.pinchart+renesas@...asonboard.com" <laurent.pinchart+renesas@...asonboard.com>,
	"yunkec@...omium.org" <yunkec@...omium.org>,
	"linux-mediatek@...ts.infradead.org" <linux-mediatek@...ts.infradead.org>,
	"linux-media@...r.kernel.org" <linux-media@...r.kernel.org>,
	"hdegoede@...hat.com" <hdegoede@...hat.com>,
	"bingbu.cao@...el.com" <bingbu.cao@...el.com>,
	"paul.elder@...asonboard.com" <paul.elder@...asonboard.com>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	Yaya Chang 張雅清 <Yaya.Chang@...iatek.com>,
	Shengnan Wang 王圣男 <shengnan.wang@...iatek.com>,
	"p.zabel@...gutronix.de" <p.zabel@...gutronix.de>,
	"alain.volmat@...s.st.com" <alain.volmat@...s.st.com>,
	"tomi.valkeinen@...asonboard.com" <tomi.valkeinen@...asonboard.com>,
	"10572168@...com" <10572168@...com>,
	"hverkuil-cisco@...all.nl" <hverkuil-cisco@...all.nl>,
	"linux-arm-kernel@...ts.infradead.org" <linux-arm-kernel@...ts.infradead.org>,
	"matthias.bgg@...il.com" <matthias.bgg@...il.com>,
	"mehdi.djait@...tlin.com" <mehdi.djait@...tlin.com>
Subject: Re: [PATCH v3 2/3] media: i2c: Add GT97xx VCM driver

Hi Andy, others,

On Thu, Jun 13, 2024 at 09:51:03PM +0200, Andy Shevchenko wrote:
> On Thu, Jun 13, 2024 at 2:05 AM Kieran Bingham
> <kieran.bingham@...asonboard.com> wrote:
> > Also - Cc: Dongchun Zhu <dongchun.zhu@...iatek.com> who is listed as the
> > DW9768 VCM driver author...
> > Quoting Zhi Mao (毛智) (2024-06-12 12:13:40)
> > > On Wed, 2024-06-12 at 09:07 +0200, AngeloGioacchino Del Regno wrote:
> 
> ...
> 
> > > Our project uses Giantec VCM hardware.
> > > For detailed vendor information, please visit: (
> > > https://en.giantec-semi.com/yqmd/164).
> > > The VCM datasheet we are referencing is provided by Giantec.
> > > Currently, the relationship between Giantec VCM and Dongwoon VCM is
> > > unclear, but Dongwoon seems to be another manufacturer of VCM
> > > hardware.
> 
> There may be plenty of manufacturers of the same/similar IPs, but it's
> not an excuse to have a duplication like this.
> 
> > > From the perspective of software driver development and maintenance, it
> > > makes sense for each vendor's hardware should have its own software
> > > driver.
> >
> > Personally, I don't think so. If two vendors make identical parts, we
> > shouldn't have two identical drivers.
> 
> Exactly! That's why we have compatible strings or other means of
> reusing the same code base as much as possible. This in particular
> reduces maintenance costs (of all means!) _a lot_.

Indeed. I'll mark these thus "rejected" in Patchwork.

If there's something that needs to be handled differently for the other
VCM, that can be taken into account in the driver.

-- 
Kind regards,

Sakari Ailus