linux-kernel - Re: [PATCH v5 2/4] interconnect: qcom: sc7280: enable QoS configuration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d6c4ceed-5804-473a-8599-405d4ace099f@quicinc.com>
Date: Fri, 21 Jun 2024 23:13:34 +0530
From: Odelu Kukatla <quic_okukatla@...cinc.com>
To: Konrad Dybcio <konrad.dybcio@...aro.org>,
        Bjorn Andersson
	<andersson@...nel.org>,
        Georgi Djakov <djakov@...nel.org>, Rob Herring
	<robh@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Conor Dooley <conor+dt@...nel.org>
CC: Kees Cook <keescook@...omium.org>, <cros-qcom-dts-watchers@...omium.org>,
        "Gustavo A . R . Silva" <gustavoars@...nel.org>,
        <linux-arm-msm@...r.kernel.org>, <linux-pm@...r.kernel.org>,
        <devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <linux-hardening@...r.kernel.org>, <quic_rlaggysh@...cinc.com>,
        <quic_mdtipton@...cinc.com>
Subject: Re: [PATCH v5 2/4] interconnect: qcom: sc7280: enable QoS
 configuration



On 6/18/2024 8:16 PM, Konrad Dybcio wrote:
> 
> 
> On 6/7/24 19:39, Odelu Kukatla wrote:
>> Enable QoS configuration for master ports with predefined values
>> for priority and urgency forawrding.
>>
>> Signed-off-by: Odelu Kukatla <quic_okukatla@...cinc.com>
>> ---
> 
> msm-5.4 also has a qhm_gic node with QoS offset 0x9000, is that of any
> importance, or can we forget it exists?
> 

qhm_gic node QoS is not that important, it is fine.

> LGTM otherwise:
> 
> Reviewed-by: Konrad Dybcio <konrad.dybcio@...aro.org>
> 
> Konrad

Thanks for the review!

Regards,
Odelu