linux-kernel - Re: [PATCH 1/3] net: stmmac: Add interconnect support in qcom-ethqos driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b5096113-de85-485e-a226-a8112b3d5490@lunn.ch>
Date: Fri, 21 Jun 2024 22:01:39 +0200
From: Andrew Lunn <andrew@...n.ch>
To: Sagar Cheluvegowda <quic_scheluve@...cinc.com>
Cc: Vinod Koul <vkoul@...nel.org>,
	Alexandre Torgue <alexandre.torgue@...s.st.com>,
	Jose Abreu <joabreu@...opsys.com>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Maxime Coquelin <mcoquelin.stm32@...il.com>,
	Russell King <linux@...linux.org.uk>, Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>,
	Bhupesh Sharma <bhupesh.sharma@...aro.org>, kernel@...cinc.com,
	Andrew Halaney <ahalaney@...hat.com>, linux-arm-msm@...r.kernel.org,
	netdev@...r.kernel.org, linux-stm32@...md-mailman.stormreply.com,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
	devicetree@...r.kernel.org
Subject: Re: [PATCH 1/3] net: stmmac: Add interconnect support in qcom-ethqos
 driver

> > This all looks pretty generic. Any reason why this is just in the
> > Qualcomm device, and not at a higher level so it could be used for all
> > stmmac devices if the needed properties are found in DT?
> > 
> >        Andrew
> ICC is a software framework to access the NOC bus topology of the
> system, all though "axi" and "ahb" buses seem generic but the 
> topologies of these NOC's are specific to the vendors of synopsys chipset hence
> this framework might not be applicable to all the vendors of stmmac driver.

There are however a number of SoCs using synopsys IP. Am i right in
says they could all make use of this? Do we really want them to one by
one copy/paste what you have here to other vendor specific parts of
stmmac?

This code looks in DT. If there are no properties in DT, it does
nothing. So in general it should be safe, right?

	 Andrew