linux-kernel - Re: [f2fs-dev] [PATCH] f2fs: assign CURSEG_ALL_DATA

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Fri, 21 Jun 2024 14:36:21 -0700
From: William McVicker <willmcvicker@...gle.com>
To: Jaegeuk Kim <jaegeuk@...nel.org>
Cc: Jaegeuk Kim <jaegeuk@...nel.org>, linux-kernel@...r.kernel.org,
	linux-f2fs-devel@...ts.sourceforge.net, stable@...r.kernel.org,
	Chao Yu <chao@...nel.org>
Subject: Re: [f2fs-dev] [PATCH] f2fs: assign CURSEG_ALL_DATA_ATGC if blkaddr
 is valid

On 06/19/2024, Chao Yu wrote:
> On 2024/6/18 10:23, Jaegeuk Kim wrote:
> > mkdir /mnt/test/comp
> > f2fs_io setflags compression /mnt/test/comp
> > dd if=/dev/zero of=/mnt/test/comp/testfile bs=16k count=1
> > truncate --size 13 /mnt/test/comp/testfile
> > 
> > In the above scenario, we can get a BUG_ON.
> >   kernel BUG at fs/f2fs/segment.c:3589!
> >   Call Trace:
> >    do_write_page+0x78/0x390 [f2fs]
> >    f2fs_outplace_write_data+0x62/0xb0 [f2fs]
> >    f2fs_do_write_data_page+0x275/0x740 [f2fs]
> >    f2fs_write_single_data_page+0x1dc/0x8f0 [f2fs]
> >    f2fs_write_multi_pages+0x1e5/0xae0 [f2fs]
> >    f2fs_write_cache_pages+0xab1/0xc60 [f2fs]
> >    f2fs_write_data_pages+0x2d8/0x330 [f2fs]
> >    do_writepages+0xcf/0x270
> >    __writeback_single_inode+0x44/0x350
> >    writeback_sb_inodes+0x242/0x530
> >    __writeback_inodes_wb+0x54/0xf0
> >    wb_writeback+0x192/0x310
> >    wb_workfn+0x30d/0x400
> > 
> > The reason is we gave CURSEG_ALL_DATA_ATGC to COMPR_ADDR where the
> > page was set the gcing flag by set_cluster_dirty().
> > 
> > Cc: stable@...r.kernel.org
> > Fixes: 4961acdd65c9 ("f2fs: fix to tag gcing flag on page during block migration")
> > Signed-off-by: Jaegeuk Kim <jaegeuk@...nel.org>
> 
> Reviewed-by: Chao Yu <chao@...nel.org>

Hi Jaegeuk,

I've been running my personal Pixel 8a device with this change for the past
3 days and haven't hit any kernal panics since applying it. Feel free to
include:

Tested-by: Will McVicker <willmcvicker@...gle.com>

Thanks,
Will