linux-kernel - Re: [PATCH] cdx: remove unused struct 'cdx_mcdi_copy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZnTDIRpC9xhH4vrO@gallifrey>
Date: Fri, 21 Jun 2024 00:02:41 +0000
From: "Dr. David Alan Gilbert" <linux@...blig.org>
To: nipun.gupta@....com, nikhil.agarwal@....com
Cc: abhijit.gangurde@....com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] cdx: remove unused struct 'cdx_mcdi_copy_buffer'

* linux@...blig.org (linux@...blig.org) wrote:
> From: "Dr. David Alan Gilbert" <linux@...blig.org>
> 
> 'cdx_mcdi_copy_buffer' has been unused since the original
> commit eb96b740192b ("cdx: add MCDI protocol interface for firmware
> interaction").
> 
> Looking at lkml,  it was used in the V1 posting but was removed
> somewhere before V6.
> 
> Remove it.
> 
> Signed-off-by: Dr. David Alan Gilbert <linux@...blig.org>

Ping.

Dave

> ---
>  drivers/cdx/controller/mcdi.c | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/drivers/cdx/controller/mcdi.c b/drivers/cdx/controller/mcdi.c
> index 1eedc5eeb315..e760f8d347cc 100644
> --- a/drivers/cdx/controller/mcdi.c
> +++ b/drivers/cdx/controller/mcdi.c
> @@ -27,10 +27,6 @@
>  #include "bitfield.h"
>  #include "mcdi.h"
>  
> -struct cdx_mcdi_copy_buffer {
> -	struct cdx_dword buffer[DIV_ROUND_UP(MCDI_CTL_SDU_LEN_MAX, 4)];
> -};
> -
>  static void cdx_mcdi_cancel_cmd(struct cdx_mcdi *cdx, struct cdx_mcdi_cmd *cmd);
>  static void cdx_mcdi_wait_for_cleanup(struct cdx_mcdi *cdx);
>  static int cdx_mcdi_rpc_async_internal(struct cdx_mcdi *cdx,
> -- 
> 2.45.1
> 
-- 
 -----Open up your eyes, open up your mind, open up your code -------   
/ Dr. David Alan Gilbert    |       Running GNU/Linux       | Happy  \ 
\        dave @ treblig.org |                               | In Hex /
 \ _________________________|_____ http://www.treblig.org   |_______/