linux-kernel - Re: [PATCH v1 2/3] net: wireless: brcmfmac: Add optional 32k clock enable support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Fri, 21 Jun 2024 07:45:20 +0000
From: Jacobe Zang <jacobe.zang@...ion.com>
To: Krzysztof Kozlowski <krzk@...nel.org>, "arend.vanspriel@...adcom.com"
	<arend.vanspriel@...adcom.com>
CC: "kvalo@...nel.org" <kvalo@...nel.org>, "duoming@....edu.cn"
	<duoming@....edu.cn>, "bhelgaas@...gle.com" <bhelgaas@...gle.com>,
	"minipli@...ecurity.net" <minipli@...ecurity.net>,
	"linux-wireless@...r.kernel.org" <linux-wireless@...r.kernel.org>,
	"brcm80211@...ts.linux.dev" <brcm80211@...ts.linux.dev>,
	"brcm80211-dev-list.pdl@...adcom.com" <brcm80211-dev-list.pdl@...adcom.com>,
	"megi@....cz" <megi@....cz>, "robh@...nel.org" <robh@...nel.org>,
	"krzk+dt@...nel.org" <krzk+dt@...nel.org>, "conor+dt@...nel.org"
	<conor+dt@...nel.org>, "heiko@...ech.de" <heiko@...ech.de>, Nick Xie
	<nick@...das.com>, "efectn@...tonmail.com" <efectn@...tonmail.com>,
	"jagan@...eble.ai" <jagan@...eble.ai>, "dsimic@...jaro.org"
	<dsimic@...jaro.org>, "devicetree@...r.kernel.org"
	<devicetree@...r.kernel.org>, "linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>, "linux-rockchip@...ts.infradead.org"
	<linux-rockchip@...ts.infradead.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v1 2/3] net: wireless: brcmfmac: Add optional 32k clock
 enable support

> That's DTS, not binding. I ask about Devicetree binding.

Ok... I have grep in all dts files and can't find wifi node which is under pcie node has clock. So should I add an example in the yaml file? 

Just like:

diff --git a/Documentation/devicetree/bindings/net/wireless/brcm,bcm4329-fmac.yaml b/Documentation/devicetree/bindings/net/wireless/brcm,bcm4329-fmac.yaml
index e564f20d8f415..2d9f8de447659 100644
--- a/Documentation/devicetree/bindings/net/wireless/brcm,bcm4329-fmac.yaml
+++ b/Documentation/devicetree/bindings/net/wireless/brcm,bcm4329-fmac.yaml
@@ -153,3 +153,19 @@ examples:
         brcm,ccode-map = "JP-JP-78", "US-Q2-86";
       };
     };
+  - |
+    pcie@0,0 {
+                 reg = <0x400000 0 0 0 0>;
+                 #address-cells = <3>;
+                 #size-cells = <2>;
+                 ranges;
+                 device_type = "pci";
+                 bus-range = <0x40 0x4f>;
+
+                 wifi: wifi@0,0 {
+                         compatible = "pci14e4,449d";
+                         reg = <0x410000 0 0 0 0>;
+                         clocks = <&hym8563>;
+                         clock-names = "32k";
+                 };
+         };

---
Best Regards
Jacobe