linux-kernel - Re: [PATCH v6 32/39] s390/ptdump: Add KMSAN page markers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Fri, 21 Jun 2024 10:20:48 +0200
From: Ilya Leoshkevich <iii@...ux.ibm.com>
To: Alexander Gordeev <agordeev@...ux.ibm.com>,
        Alexander Potapenko
 <glider@...gle.com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Christoph
 Lameter <cl@...ux.com>,
        David Rientjes <rientjes@...gle.com>,
        Heiko
 Carstens <hca@...ux.ibm.com>,
        Joonsoo Kim <iamjoonsoo.kim@....com>, Marco
 Elver <elver@...gle.com>,
        Masami Hiramatsu <mhiramat@...nel.org>,
        Pekka
 Enberg <penberg@...nel.org>,
        Steven Rostedt <rostedt@...dmis.org>,
        Vasily
 Gorbik <gor@...ux.ibm.com>, Vlastimil Babka <vbabka@...e.cz>
Cc: Christian Borntraeger <borntraeger@...ux.ibm.com>,
        Dmitry Vyukov
 <dvyukov@...gle.com>,
        Hyeonggon Yoo <42.hyeyoo@...il.com>, kasan-dev@...glegroups.com,
        linux-kernel@...r.kernel.org, linux-mm@...ck.org,
        linux-s390@...r.kernel.org, linux-trace-kernel@...r.kernel.org,
        Mark Rutland <mark.rutland@....com>,
        Roman Gushchin <roman.gushchin@...ux.dev>,
        Sven Schnelle
 <svens@...ux.ibm.com>
Subject: Re: [PATCH v6 32/39] s390/ptdump: Add KMSAN page markers

On Fri, 2024-06-21 at 02:25 +0200, Ilya Leoshkevich wrote:
> Add KMSAN vmalloc metadata areas to kernel_page_tables.
> 
> Signed-off-by: Ilya Leoshkevich <iii@...ux.ibm.com>
> ---
>  arch/s390/mm/dump_pagetables.c | 30 ++++++++++++++++++++++++++++++
>  1 file changed, 30 insertions(+)
> 
> diff --git a/arch/s390/mm/dump_pagetables.c
> b/arch/s390/mm/dump_pagetables.c
> index ffd07ed7b4af..f51e5d0862a3 100644
> --- a/arch/s390/mm/dump_pagetables.c
> +++ b/arch/s390/mm/dump_pagetables.c
> @@ -36,6 +36,16 @@ enum address_markers_idx {
>  	VMEMMAP_END_NR,
>  	VMALLOC_NR,
>  	VMALLOC_END_NR,
> +#ifdef CONFIG_KMSAN
> +	KMSAN_VMALLOC_SHADOW_START_NR,
> +	KMSAN_VMALLOC_SHADOW_END_NR,
> +	KMSAN_VMALLOC_ORIGIN_START_NR,
> +	KMSAN_VMALLOC_ORIGIN_END_NR,
> +	KMSAN_MODULES_SHADOW_START_NR,
> +	KMSAN_MODULES_SHADOW_END_NR,
> +	KMSAN_MODULES_ORIGIN_START_NR,
> +	KMSAN_MODULES_ORIGIN_END_NR,
> +#endif
>  	MODULES_NR,
>  	MODULES_END_NR,
>  	ABS_LOWCORE_NR,
> @@ -74,6 +84,16 @@ static struct addr_marker address_markers[] = {
>  #ifdef CONFIG_KASAN
>  	[KASAN_SHADOW_START_NR]	= {KASAN_SHADOW_START,
> "Kasan Shadow Start"},
>  	[KASAN_SHADOW_END_NR]	= {KASAN_SHADOW_END, "Kasan Shadow
> End"},
> +#endif
> +#ifdef CONFIG_KMSAN
> +	[KMSAN_VMALLOC_SHADOW_START_NR]	= {0, "Kmsan vmalloc
> Shadow Start"},
> +	[KMSAN_VMALLOC_SHADOW_END_NR]	= {0, "Kmsan vmalloc Shadow
> End"},
> +	[KMSAN_VMALLOC_ORIGIN_START_NR]	= {0, "Kmsan vmalloc
> Origins Start"},
> +	[KMSAN_VMALLOC_ORIGIN_END_NR]	= {0, "Kmsan vmalloc Origins
> End"},
> +	[KMSAN_MODULES_SHADOW_START_NR]	= {0, "Kmsan Modules
> Shadow Start"},
> +	[KMSAN_MODULES_SHADOW_END_NR]	= {0, "Kmsan Modules Shadow
> End"},
> +	[KMSAN_MODULES_ORIGIN_START_NR]	= {0, "Kmsan Modules
> Origins Start"},
> +	[KMSAN_MODULES_ORIGIN_END_NR]	= {0, "Kmsan Modules Origins
> End"},
>  #endif

Please disregard this patch. It's not essential for the series, and
also has a subtle bug: this block needs to be moved upwards, because
right now { -1, NULL } overlaps [MODULES_NR]. I will resend it
separately later.

>  	{ -1, NULL }
>  };