linux-kernel - Re: [PATCH v2 net-next] net: dsa: Allow only up to two HSR HW offloaded ports for KSZ9477

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20240621084346.4v5xc672zojr6dc2@skbuf>
Date: Fri, 21 Jun 2024 11:43:46 +0300
From: Vladimir Oltean <olteanv@...il.com>
To: Lukasz Majewski <lukma@...x.de>
Cc: Jakub Kicinski <kuba@...nel.org>, netdev@...r.kernel.org,
	Paolo Abeni <pabeni@...hat.com>, Eric Dumazet <edumazet@...gle.com>,
	"David S. Miller" <davem@...emloft.net>,
	Oleksij Rempel <o.rempel@...gutronix.de>, Tristram.Ha@...rochip.com,
	Sebastian Andrzej Siewior <bigeasy@...utronix.de>,
	Simon Horman <horms@...nel.org>,
	Dan Carpenter <dan.carpenter@...aro.org>,
	"Ricardo B. Marliere" <ricardo@...liere.net>,
	Casper Andersson <casper.casan@...il.com>,
	linux-kernel@...r.kernel.org,
	Woojung Huh <woojung.huh@...rochip.com>,
	UNGLinuxDriver@...rochip.com, Andrew Lunn <andrew@...n.ch>
Subject: Re: [PATCH v2 net-next] net: dsa: Allow only up to two HSR HW
 offloaded ports for KSZ9477

On Fri, Jun 21, 2024 at 10:31:44AM +0200, Lukasz Majewski wrote:
> > That being said, I think the responsibility falls on your side here,
> > given that you introduced a new HSR port type and offload drivers
> > still implicitly think it's a ring port, because there's no API to
> > tell them otherwise.
> 
> IMHO, the above problem is not related to the patch send here. It shall
> be addressed with new patch series.

Why is it not related? Testing for HSR port type is the explicit and
more predictable variant of your current patch that waits for the
3rd NETDEV_CHANGEUPPER notifier and implicitly associates it with an
interlink port. If you're going to add the ability to test for HSR port
type in offloading drivers anyway, I don't understand why you wouldn't
want to opt for a uniform approach in ksz9477.