linux-kernel - Re: [PATCH] wifi: mwifiex: increase max_num_akm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZnU-STTaTWjHViwW@pengutronix.de>
Date: Fri, 21 Jun 2024 10:48:09 +0200
From: Sascha Hauer <s.hauer@...gutronix.de>
To: Brian Norris <briannorris@...omium.org>
Cc: linux-wireless@...r.kernel.org, linux-kernel@...r.kernel.org,
	Francesco Dolcini <francesco@...cini.it>,
	Kalle Valo <kvalo@...nel.org>, David Lin <yu-hao.lin@....com>
Subject: Re: [PATCH] wifi: mwifiex: increase max_num_akm_suites

On Thu, Jun 20, 2024 at 11:05:24AM -0700, Brian Norris wrote:
> Hi Sascha,
> 
> On Thu, May 30, 2024 at 03:01:56PM +0200, Sascha Hauer wrote:
> > The maximum number of AKM suites will be set to two if not specified by
> > the driver. Set it to CFG80211_MAX_NUM_AKM_SUITES to let userspace
> > specify up to ten AKM suites in the akm_suites array.
> > 
> > Without only the first two AKM suites will be used, further ones are
> > ignored.
> > 
> > Signed-off-by: Sascha Hauer <s.hauer@...gutronix.de>
> > ---
> > 
> > Current wpa_supplicant/hostapd only put a maximum of two into the
> > akm_suites array as well, a patch changing this can be found here:
> > http://lists.infradead.org/pipermail/hostap/2024-May/042720.html
> 
> Thanks for the patches and research.
> 
> Possibly dumb question: what's unique about mwifiex here? Everything you
> describe above sounds applicable to all drivers, IIUC, and I don't see
> any other driver that touches max_num_akm_suites.

I asked myself the same question and I don't have an answer to it. To me
it looks like the number of akm suites is limited by the akm_suites array
size which is CFG80211_MAX_NUM_AKM_SUITES which is 10 and that could be
used for all drivers.
max_num_akm_suites is introduced to be driver specific and so I changed
it only for the driver I am currently interested in.

Sascha

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |