linux-kernel - Re: [PATCH] drm/qxl: Add check for drm_cvt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <78a99414-314d-452e-938b-07e86182a8bf@linux.alibaba.com>
Date: Fri, 21 Jun 2024 16:48:13 +0800
From: Heng Qi <hengqi@...ux.alibaba.com>
To: Chen Ni <nichen@...as.ac.cn>
Cc: virtualization@...ts.linux.dev, spice-devel@...ts.freedesktop.org,
 dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org,
 airlied@...hat.com, kraxel@...hat.com, maarten.lankhorst@...ux.intel.com,
 mripard@...nel.org, tzimmermann@...e.de, airlied@...il.com, daniel@...ll.ch,
 noralf@...nnes.org
Subject: Re: [PATCH] drm/qxl: Add check for drm_cvt_mode


在 2024/6/21 下午3:10, Chen Ni 写道:
> Add check for the return value of drm_cvt_mode() and return the error if
> it fails in order to avoid NULL pointer dereference.
>
> Fixes: 1b043677d4be ("drm/qxl: add qxl_add_mode helper function")
> Signed-off-by: Chen Ni <nichen@...as.ac.cn>
> ---
>   drivers/gpu/drm/qxl/qxl_display.c | 3 +++
>   1 file changed, 3 insertions(+)
>
> diff --git a/drivers/gpu/drm/qxl/qxl_display.c b/drivers/gpu/drm/qxl/qxl_display.c
> index c6d35c33d5d6..86a5dea710c0 100644
> --- a/drivers/gpu/drm/qxl/qxl_display.c
> +++ b/drivers/gpu/drm/qxl/qxl_display.c
> @@ -236,6 +236,9 @@ static int qxl_add_mode(struct drm_connector *connector,
>   		return 0;
>   
>   	mode = drm_cvt_mode(dev, width, height, 60, false, false, false);
> +	if (!mode)
> +		return 0;
> +
>   	if (preferred)
>   		mode->type |= DRM_MODE_TYPE_PREFERRED;
>   	mode->hdisplay = width;

Reviewed-by: Heng Qi <hengqi@...ux.alibaba.com>

Thanks.