linux-kernel - Re: [PATCH v3 1/2] dt-bindings: pinctrl: aspeed,ast2600-pinctrl: add NCSI group

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Fri, 21 Jun 2024 10:16:04 +0930
From: Andrew Jeffery <andrew@...econstruct.com.au>
To: Potin Lai <potin.lai.pt@...il.com>, Linus Walleij
 <linus.walleij@...aro.org>,  Rob Herring <robh+dt@...nel.org>, Krzysztof
 Kozlowski <krzysztof.kozlowski+dt@...aro.org>, Conor Dooley
 <conor+dt@...nel.org>, Joel Stanley <joel@....id.au>
Cc: linux-aspeed@...ts.ozlabs.org, openbmc@...ts.ozlabs.org, 
 linux-gpio@...r.kernel.org, devicetree@...r.kernel.org, 
 linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org, Patrick
 Williams <patrick@...cx.xyz>, Cosmo Chou <cosmo.chou@...ntatw.com>, Potin
 Lai <potin.lai@...ntatw.com>,  Krzysztof Kozlowski
 <krzysztof.kozlowski@...aro.org>
Subject: Re: [PATCH v3 1/2] dt-bindings: pinctrl: aspeed,ast2600-pinctrl:
 add NCSI group

Hi Potin,

On Thu, 2024-06-20 at 16:43 +0800, Potin Lai wrote:
> In the NCSI pin table, the reference clock output pin (RMIIXRCLKO) is not
> needed on the management controller side.
> 
> Add NCSI group to distinguish the pin group between RMII and NCSI.
> 
> - RMII pins:
>   - RMIIXRCLKI
>   - RMIIXRXD0
>   - RMIIXRXD1
>   - RMIIXCRSDV
>   - RMIIXRXER
>   - RMIIXRCLKO
>   - RMIIXTXEN
>   - RMIIXTXD0
>   - RMIIXTXD1
> 
> - NCSI pins:
>   - RMIIXRCLKI
>   - RMIIXRXD0
>   - RMIIXRXD1
>   - RMIIXCRSDV
>   - RMIIXRXER
>   - RMIIXTXEN
>   - RMIIXTXD0
>   - RMIIXTXD1

I think listing all the pins for both groups obscures the fact that
there aren't more changes than removing RMIIXRCLKO.

Can we instead drop these lists and replace

> Add NCSI group to distinguish the pin group between RMII and NCSI.

With:

> Add "NCSI" pin groups that are equivalent to the RMII pin groups,
> but without the RMIIXRCLKO pin

?

> 
> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> Signed-off-by: Potin Lai <potin.lai.pt@...il.com>
> ---
>  .../devicetree/bindings/pinctrl/aspeed,ast2600-pinctrl.yaml     | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/pinctrl/aspeed,ast2600-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/aspeed,ast2600-pinctrl.yaml
> index 00b6974a5ed3d..3f02dc94a7ce2 100644
> --- a/Documentation/devicetree/bindings/pinctrl/aspeed,ast2600-pinctrl.yaml
> +++ b/Documentation/devicetree/bindings/pinctrl/aspeed,ast2600-pinctrl.yaml
> @@ -337,6 +337,8 @@ additionalProperties:
>          - MDIO2
>          - MDIO3
>          - MDIO4
> +        - NCSI3
> +        - NCSI4

Can we also do this for RMII{1,2}RCLKO (and in the driver patch as
well)?

>          - NCTS1
>          - NCTS2
>          - NCTS3

Overall, what I was hoping for with the comment on the earlier patch
was that you would add the discussion in the commit message to the
"description" entry in the binding YAML. Can you please do so? That way
the information is always present for people reading the binding
without them having to look at the binding's change history.

Thanks,

Andrew