linux-kernel - [PATCH] iio: adc: ad_sigma_delta: fix disable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date: Fri, 21 Jun 2024 15:05:39 +0300
From: Dumitru Ceclan <mitrutzceclan@...il.com>
To: mitrutzceclan@...il.com
Cc: jic23@...nel.org,
	dlechner@...libre.com,
	dumitru.ceclan@...log.com0,
	linux-iio@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	Dumitru Ceclan <dumitru.ceclan@...log.com>
Subject: [PATCH] iio: adc: ad_sigma_delta: fix disable_one callback

The ADC ad7192 is a sigma delta ADC with a sequencer that does not
require a disable_one callback as all enable channel bits are within
the same register.

Remove the requirement of the disable_one callback for sigma delta ADCs
with a sequencer.

This patch could be squashed with the commit that it fixes from patch
series: Add support for AD411x

Fixes: a25a0aab2187 ("iio: adc: ad_sigma_delta: add disable_one callback")
Signed-off-by: Dumitru Ceclan <dumitru.ceclan@...log.com>
---
 drivers/iio/adc/ad_sigma_delta.c | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/drivers/iio/adc/ad_sigma_delta.c b/drivers/iio/adc/ad_sigma_delta.c
index d6b5fca034a0..8c062b0d26e3 100644
--- a/drivers/iio/adc/ad_sigma_delta.c
+++ b/drivers/iio/adc/ad_sigma_delta.c
@@ -672,11 +672,6 @@ int ad_sd_init(struct ad_sigma_delta *sigma_delta, struct iio_dev *indio_dev,
 			dev_err(&spi->dev, "ad_sigma_delta_info lacks disable_all().\n");
 			return -EINVAL;
 		}
-
-		if (!info->disable_one) {
-			dev_err(&spi->dev, "ad_sigma_delta_info lacks disable_one().\n");
-			return -EINVAL;
-		}
 	}
 
 	if (info->irq_line)
-- 
2.43.0