linux-kernel - Re: kernel/kcov.c:635:32: error: 'KCOV_MODE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZnVzn3YtNi5+mkLe@rli9-mobl>
Date: Fri, 21 Jun 2024 20:35:43 +0800
From: Philip Li <philip.li@...el.com>
To: Aleksandr Nogikh <nogikh@...gle.com>
CC: kernel test robot <lkp@...el.com>, <oe-kbuild-all@...ts.linux.dev>,
	<linux-kernel@...r.kernel.org>, Andrew Morton <akpm@...ux-foundation.org>,
	Linux Memory Management List <linux-mm@...ck.org>, Dmitry Vyukov
	<dvyukov@...gle.com>, Andrey Konovalov <andreyknvl@...il.com>
Subject: Re: kernel/kcov.c:635:32: error: 'KCOV_MODE_REMOTE' undeclared

On Fri, Jun 21, 2024 at 12:18:44PM +0200, Aleksandr Nogikh wrote:
> On Thu, Jun 20, 2024 at 9:53 AM kernel test robot <lkp@...el.com> wrote:
> >
> > tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> > head:   e5b3efbe1ab1793bb49ae07d56d0973267e65112
> > commit: 01c8f9806bde438ca1c8cbbc439f0a14a6694f6c kcov: don't lose track of remote references during softirqs
> > date:   5 days ago
> > config: x86_64-randconfig-014-20240202 (https://download.01.org/0day-ci/archive/20240620/202406201538.SMBucNWT-lkp@intel.com/config)
> > compiler: gcc-13 (Ubuntu 13.2.0-4ubuntu3) 13.2.0
> > reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240620/202406201538.SMBucNWT-lkp@intel.com/reproduce)
> >
> > If you fix the issue in a separate patch/commit (i.e. not just a new version of
> > the same patch/commit), kindly add following tags
> > | Reported-by: kernel test robot <lkp@...el.com>
> > | Closes: https://lore.kernel.org/oe-kbuild-all/202406201538.SMBucNWT-lkp@intel.com/
> >
> 
> I was unable to reproduce the problem with the attached config/script.

Sorry, this should be a wrong report. We will fix the bot asap to avoid false positive.

> 
> > All errors (new ones prefixed by >>):
> >
> >          |                     ^~
> >    include/asm-generic/rwonce.h:55:27: note: in definition of macro '__WRITE_ONCE'
> >       55 |         *(volatile typeof(x) *)&(x) = (val);                            \
> >          |                           ^
> >    kernel/kcov.c:363:9: note: in expansion of macro 'WRITE_ONCE'
> >      363 |         WRITE_ONCE(t->kcov_mode, KCOV_MODE_DISABLED);
> >          |         ^~~~~~~~~~
> >    kernel/kcov.c:363:21: error: 'struct task_struct' has no member named 'kcov_mode'
> >      363 |         WRITE_ONCE(t->kcov_mode, KCOV_MODE_DISABLED);
> 
> It looks as if CONFIG_KCOV is not enabled, but
> 1) It is enabled in the attached config file.
> 2) If it's not enabled, the kernel/kcov.c file should not have been
> compiled in the first place.
> 
> >          |                     ^~
> >    include/asm-generic/rwonce.h:55:34: note: in definition of macro '__WRITE_ONCE'
> >       55 |         *(volatile typeof(x) *)&(x) = (val);                            \
> >          |                                  ^
> >    kernel/kcov.c:363:9: note: in expansion of macro 'WRITE_ONCE'
> >      363 |         WRITE_ONCE(t->kcov_mode, KCOV_MODE_DISABLED);
> >          |         ^~~~~~~~~~
> >    kernel/kcov.c:363:34: error: 'KCOV_MODE_DISABLED' undeclared (first use in this function); did you mean 'KCOV_DISABLE'?
> >      363 |         WRITE_ONCE(t->kcov_mode, KCOV_MODE_DISABLED);
> 
> This looks again as if CONFIG_KCOV is not set (and there follow the
> same two conclusions).
> 
> -- 
> Aleksandr
>