linux-kernel - Re: [PATCH v1] tpm_tis_spi: add missing attpm20p SPI device ID entry

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZnaUYICRxvSG-sTX@wunner.de>
Date: Sat, 22 Jun 2024 11:07:44 +0200
From: Lukas Wunner <lukas@...ner.de>
To: Vitor Soares <ivitro@...il.com>
Cc: Peter Huewe <peterhuewe@....de>, Jarkko Sakkinen <jarkko@...nel.org>,
	Jason Gunthorpe <jgg@...pe.ca>,
	Vitor Soares <vitor.soares@...adex.com>,
	linux-integrity@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1] tpm_tis_spi: add missing attpm20p SPI device ID entry

[removing stable@...r.kernel.org from cc -- they're only interested
in your patch once it's in Linus' tree]

On Fri, Jun 21, 2024 at 10:50:45AM +0100, Vitor Soares wrote:
> "atmel,attpm20p" DT compatible is missing its SPI device ID entry, not
> allowing module autoloading and leading to the following message:
> 
>   "SPI driver tpm_tis_spi has no spi_device_id for atmel,attpm20p"
[...]
> Fix this by adding the corresponding "attpm20p" spi_device_id entry.
> 
> Fixes: 3c45308c44ed ("tpm_tis_spi: Add compatible string atmel,attpm20p")
> Cc: stable@...r.kernel.org
> Signed-off-by: Vitor Soares <vitor.soares@...adex.com>

Reviewed-by: Lukas Wunner <lukas@...ner.de>

The old problem that spi modules aren't auto-loaded based on
MODULE_DEVICE_TABLE(of, ...), but only on MODULE_DEVICE_TABLE(spi, ...):

https://lore.kernel.org/all/20170811081429.GA9957@wunner.de/

Completely forgot that this is still a problem after all these years. :(

Thanks,

Lukas