linux-kernel - Re: [PATCH v3 02/41] iio: accel: kxsd9: Make use of regmap_clear

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240622104319.60b0f0d5@jic23-huawei>
Date: Sat, 22 Jun 2024 10:43:19 +0100
From: Jonathan Cameron <jic23@...nel.org>
To: Trevor Gamblin <tgamblin@...libre.com>
Cc: Lars-Peter Clausen <lars@...afoo.de>, Dmitry Rokosov
 <ddrokosov@...rdevices.ru>, Michael Hennerich
 <Michael.Hennerich@...log.com>, Cosmin Tanislav
 <cosmin.tanislav@...log.com>, Chen-Yu Tsai <wens@...e.org>, Hans de Goede
 <hdegoede@...hat.com>, Ray Jui <rjui@...adcom.com>, Scott Branden
 <sbranden@...adcom.com>, Broadcom internal kernel review list
 <bcm-kernel-feedback-list@...adcom.com>, Shawn Guo <shawnguo@...nel.org>,
 Sascha Hauer <s.hauer@...gutronix.de>, Pengutronix Kernel Team
 <kernel@...gutronix.de>, Fabio Estevam <festevam@...il.com>, Neil Armstrong
 <neil.armstrong@...aro.org>, Kevin Hilman <khilman@...libre.com>, Jerome
 Brunet <jbrunet@...libre.com>, Martin Blumenstingl
 <martin.blumenstingl@...glemail.com>, Saravanan Sekar
 <sravanhome@...il.com>, Orson Zhai <orsonzhai@...il.com>, Baolin Wang
 <baolin.wang@...ux.alibaba.com>, Chunyan Zhang <zhang.lyra@...il.com>,
 Maxime Coquelin <mcoquelin.stm32@...il.com>, Alexandre Torgue
 <alexandre.torgue@...s.st.com>, Nuno Sá <nuno.sa@...log.com>,
 Linus Walleij <linus.walleij@...aro.org>, Jean-Baptiste Maneyrol
 <jmaneyrol@...ensense.com>, Crt Mori <cmo@...exis.com>,
 linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-arm-kernel@...ts.infradead.org, imx@...ts.linux.dev,
 linux-amlogic@...ts.infradead.org, linux-arm-msm@...r.kernel.org,
 linux-stm32@...md-mailman.stormreply.com, Uwe Kleine-König <u.kleine-koenig@...libre.com>
Subject: Re: [PATCH v3 02/41] iio: accel: kxsd9: Make use of
 regmap_clear_bits()

On Mon, 17 Jun 2024 09:49:42 -0400
Trevor Gamblin <tgamblin@...libre.com> wrote:

> Instead of using regmap_update_bits() and passing val = 0, use
> regmap_clear_bits().
> 
> Suggested-by: Uwe Kleine-König <u.kleine-koenig@...libre.com>
> Signed-off-by: Trevor Gamblin <tgamblin@...libre.com>
> ---
>  drivers/iio/accel/kxsd9.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/iio/accel/kxsd9.c b/drivers/iio/accel/kxsd9.c
> index ba99649fe195..03ce032e06ff 100644
> --- a/drivers/iio/accel/kxsd9.c
> +++ b/drivers/iio/accel/kxsd9.c
> @@ -370,10 +370,8 @@ static int kxsd9_power_down(struct kxsd9_state *st)
>  	 * make sure we conserve power even if there are others users on the
>  	 * regulators.
>  	 */
> -	ret = regmap_update_bits(st->map,
> -				 KXSD9_REG_CTRL_B,
> -				 KXSD9_CTRL_B_ENABLE,
> -				 0);
> +	ret = regmap_clear_bits(st->map, KXSD9_REG_CTRL_B,
> +				KXSD9_CTRL_B_ENABLE);
Now fits neatly on one line at precisely 80 chars.
I rewrapped whilst applying.

Jonathan

>  	if (ret)
>  		return ret;
>  
>