linux-kernel - Re: [PATCH 1/1] dt-bindings: nvmem: sfp: add child node unique-id

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20240622-tux-jelly-b71418bfb210@spud>
Date: Sat, 22 Jun 2024 12:48:52 +0100
From: Conor Dooley <conor@...nel.org>
To: Frank Li <Frank.Li@....com>
Cc: Srinivas Kandagatla <srinivas.kandagatla@...aro.org>,
	Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>,
	Michael Walle <michael@...le.cc>,
	"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" <devicetree@...r.kernel.org>,
	open list <linux-kernel@...r.kernel.org>, imx@...ts.linux.dev
Subject: Re: [PATCH 1/1] dt-bindings: nvmem: sfp: add child node unique-id

On Fri, Jun 21, 2024 at 12:56:37PM -0400, Frank Li wrote:
> Add child node unique-id to fix below CHECK_DTBS warning.
> efuse@...0000: Unevaluated properties are not allowed ('unique-id@1c' was unexpected)

That's not sufficient justification. Why is this even needed? What can't
it be determined from a compatible etc? Just because it slipped into a
dts doesn't mean you get to avoid the usual requirements for justifying
new properties.

Thanks,
Conor.

> 
> Signed-off-by: Frank Li <Frank.Li@....com>
> ---
>  .../bindings/nvmem/fsl,layerscape-sfp.yaml      | 17 +++++++++++++++++
>  1 file changed, 17 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/nvmem/fsl,layerscape-sfp.yaml b/Documentation/devicetree/bindings/nvmem/fsl,layerscape-sfp.yaml
> index 70fb2ad251037..8c0bdaab711a7 100644
> --- a/Documentation/devicetree/bindings/nvmem/fsl,layerscape-sfp.yaml
> +++ b/Documentation/devicetree/bindings/nvmem/fsl,layerscape-sfp.yaml
> @@ -42,6 +42,23 @@ properties:
>        The regulator for the TA_PROG_SFP pin. It will be enabled for programming
>        and disabled for reading.
>  
> +patternProperties:
> +  '^unique-id@[0-9a-f]*$':
> +    type: object
> +    description:
> +      Chip unique id.
> +
> +    properties:
> +      reg:
> +        description:
> +          Byte offset where the unique id is stored
> +        maxItems: 1
> +
> +    required:
> +      - reg
> +
> +    additionalProperties: false
> +
>  required:
>    - compatible
>    - reg
> -- 
> 2.34.1
> 

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)