linux-kernel - Re: [PATCH 2/2] ASoC: Add support for ti,pcm5242 to the pcm512x driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <CE6B5FD2-790B-431F-BC69-4429CE26802A@gmail.com>
Date: Sat, 22 Jun 2024 17:05:47 +0400
From: Christian Hewitt <christianshewitt@...il.com>
To: Mark Brown <broonie@...nel.org>
Cc: Liam Girdwood <lgirdwood@...il.com>,
 Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>,
 Shenghao Ding <shenghao-ding@...com>,
 Kevin Lu <kevin-lu@...com>,
 Baojun Xu <baojun.xu@...com>,
 Jaroslav Kysela <perex@...ex.cz>,
 Takashi Iwai <tiwai@...e.com>,
 linux-sound@...r.kernel.org,
 devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org,
 alsa-devel@...a-project.org
Subject: Re: [PATCH 2/2] ASoC: Add support for ti,pcm5242 to the pcm512x
 driver

> On 22 Jun 2024, at 5:03 PM, Mark Brown <broonie@...nel.org> wrote:
> 
> On Sat, Jun 22, 2024 at 12:46:03PM +0000, Christian Hewitt wrote:
>> Add a compatible string to enable support for the ti,pcm5242 DAC chip
>> in the pcm512x driver.
>> 
>> Signed-off-by: Christian Hewitt <christianshewitt@...il.com>
>> ---
>> sound/soc/codecs/pcm512x-i2c.c | 2 ++
>> 1 file changed, 2 insertions(+)
> 
> The device appears to have SPI support too like the other devices in the
> family, why not add the ID for SPI as well:
> 
>   https://www.ti.com/product/PCM5242

Okay, will do. I need to send v2 anyway as I fat-fingered the chip
number in the bindings patch subject/description :(

Christian