linux-kernel - [PATCH v2 0/3] fs/file.c: optimize the critical section of file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Sat, 22 Jun 2024 11:49:01 -0400
From: Yu Ma <yu.ma@...el.com>
To: viro@...iv.linux.org.uk,
	brauner@...nel.org,
	jack@...e.cz,
	mjguzik@...il.com,
	edumazet@...gle.com
Cc: yu.ma@...el.com,
	linux-fsdevel@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	pan.deng@...el.com,
	tianyou.li@...el.com,
	tim.c.chen@...el.com,
	tim.c.chen@...ux.intel.com
Subject: [PATCH v2 0/3] fs/file.c: optimize the critical section of file_lock in

pts/blogbench-1.1.0 is a benchmark designed to replicate the
load of a real-world busy file server by multiple threads of
random reads, writes, and rewrites. When running default configuration
with multiple parallel threads, hot spin lock contention is observed
from alloc_fd(), file_closed_fd() and put_unused_fd() around file_lock.

These 3 patches are created to reduce the critical section of file_lock
in alloc_fd() and close_fd(). As a result, pts/blogbench-1.1.0 has been
improved by 32% for read and 17% for write with over 30% kernel cycles
reduced on ICX 160 cores configuration with v6.10-rc4.

v1 -> v2:
1. Rebased the patch set to latest v6.10-rc4 and updated the performance
results.
2. Updated patch 1 to resolve the bug identified by Mateusz Guzik with rlimit
check and ensure allocated fd is greater than start.
3. Updated patch 3 to remove sanity_check directly per the alignment with
maintainer

Yu Ma (3):
  fs/file.c: add fast path in alloc_fd()
  fs/file.c: conditionally clear full_fds
  fs/file.c: remove sanity_check from alloc_fd()

 fs/file.c | 46 ++++++++++++++++++++++++----------------------
 1 file changed, 24 insertions(+), 22 deletions(-)

base-commit: 6ba59ff4227927d3a8530fc2973b80e94b54d58f
-- 
2.43.0