linux-kernel - [PATCH v2] binder: frozen notification

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20240622031600.3762859-3-yutingtseng@google.com>
Date: Fri, 21 Jun 2024 20:16:01 -0700
From: Yu-Ting Tseng <yutingtseng@...gle.com>
To: cmllamas@...gle.com, tkjos@...gle.com, gregkh@...uxfoundation.org
Cc: arve@...roid.com, maco@...roid.com, joel@...lfernandes.org, 
	brauner@...nel.org, surenb@...gle.com, aliceryhl@...gle.com, 
	kernel-team@...roid.com, linux-kernel@...r.kernel.org, 
	Yu-Ting Tseng <yutingtseng@...gle.com>
Subject: [PATCH v2] binder: frozen notification


Yu-Ting Tseng (1):
  binder: frozen notification

 drivers/android/binder.c            | 294 +++++++++++++++++++++++++++-
 drivers/android/binder_internal.h   |  19 +-
 include/uapi/linux/android/binder.h |  35 ++++
 3 files changed, 344 insertions(+), 4 deletions(-)

> nit: typo in "state"
Fixed

> It might be cleaner to factor out this copy_form_user() part
Done

> avoid WARNs
Done

> Shouldn't this return -ENOMEM or something
Done

> This "BC_REQUEST_FREEZE_NOTIFICATION" can be in the string directly.
Done

> > +     struct binder_ref_freeze *freeze = NULL;
> This doesn't need to be initialized.
Done

> This "BC_CLEAR_FREEZE_NOTIFICATION" can be in the string directly.
Done

> "freeze" has not been assigned here, right?
Fixed

> The preferred style for comments...
Fixed

> reversed christmas tree for variables
Done

> Why is entry on a new line
Done

> shorten the name of these functions
Done

> Do we need two different work types
Merged the two

> This should come after the variable declarations
Done

> write a short explanation of what this means to userspace instead
Done

> Use scripts/get_maintainer.pl
Done

> the corrisponding changes to userspace
Please see https://android-review.googlesource.com/c/platform/frameworks/native/+/3070045

> Multiple put_user() calls seems slow
Changed to copy_to_user


base-commit: 14d7c92f8df9c0964ae6f8b813c1b3ac38120825
-- 
2.45.2.741.gdbec12cfda-goog