linux-kernel - Re: [Patch v1] EDAC/dmc520: Use devm_platform_ioremap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20240623090148.GAZnfkfCvwvLQCUeGN@fat_crate.local>
Date: Sun, 23 Jun 2024 11:01:48 +0200
From: Borislav Petkov <bp@...en8.de>
To: Jai Arora <jai.arora@...sung.com>
Cc: tony.luck@...el.com, james.morse@....com, mchehab@...nel.org,
	rric@...nel.org, linux-edac@...r.kernel.org,
	linux-kernel@...r.kernel.org, gost.dev@...sung.com,
	aswani.reddy@...sung.com, pankaj.dubey@...sung.com
Subject: Re: [Patch v1] EDAC/dmc520: Use devm_platform_ioremap_resource()

On Tue, Jun 18, 2024 at 04:32:26PM +0530, Jai Arora wrote:
> platform_get_resource() and devm_ioremap_resource() are wrapped up in the
> devm_platform_ioremap_resource() helper. Use the helper and get rid of the
> local variable for struct resource *. We now have a function call less.
> 
> Signed-off-by: Jai Arora <jai.arora@...sung.com>
> ---
>  drivers/edac/dmc520_edac.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/edac/dmc520_edac.c b/drivers/edac/dmc520_edac.c
> index 4e30b989a1a4..5e52d31db3b8 100644
> --- a/drivers/edac/dmc520_edac.c
> +++ b/drivers/edac/dmc520_edac.c
> @@ -480,7 +480,6 @@ static int dmc520_edac_probe(struct platform_device *pdev)
>  	struct mem_ctl_info *mci;
>  	void __iomem *reg_base;
>  	u32 irq_mask_all = 0;
> -	struct resource *res;
>  	struct device *dev;
>  	int ret, idx, irq;
>  	u32 reg_val;
> @@ -505,8 +504,7 @@ static int dmc520_edac_probe(struct platform_device *pdev)
>  	}
>  
>  	/* Initialize dmc520 edac */
> -	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> -	reg_base = devm_ioremap_resource(dev, res);
> +	reg_base = devm_platform_ioremap_resource(pdev, 0);
>  	if (IS_ERR(reg_base))
>  		return PTR_ERR(reg_base);
>  
> -- 

Applied, thanks.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette