linux-kernel - Re: [PATCH v2 1/3] dt-bindings: iio: accel: add ADXL380

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20240623112649.12d7ab80@jic23-huawei>
Date: Sun, 23 Jun 2024 11:26:49 +0100
From: Jonathan Cameron <jic23@...nel.org>
To: Antoniu Miclaus <antoniu.miclaus@...log.com>
Cc: Ramona Gradinariu <ramona.gradinariu@...log.com>, Lars-Peter Clausen
 <lars@...afoo.de>, Michael Hennerich <Michael.Hennerich@...log.com>, Rob
 Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor
 Dooley <conor+dt@...nel.org>, Jonathan Corbet <corbet@....net>, Matti
 Vaittinen <mazziesaccount@...il.com>, Jun Yan <jerrysteve1101@...il.com>,
 Mehdi Djait <mehdi.djait.k@...il.com>, Mario Limonciello
 <mario.limonciello@....com>, <linux-iio@...r.kernel.org>,
 <devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
 <linux-doc@...r.kernel.org>
Subject: Re: [PATCH v2 1/3] dt-bindings: iio: accel: add ADXL380

On Fri, 21 Jun 2024 13:17:03 +0300
Antoniu Miclaus <antoniu.miclaus@...log.com> wrote:

> From: Ramona Gradinariu <ramona.gradinariu@...log.com>
> 
> Add dt-bindings for ADXL380/ADLX382 low noise density, low
> power, 3-axis accelerometer with selectable measurement ranges.
> 
> Signed-off-by: Ramona Gradinariu <ramona.gradinariu@...log.com>
> Signed-off-by: Antoniu Miclaus <antoniu.miclaus@...log.com>
> ---
>  .../bindings/iio/accel/adi,adxl380.yaml       | 83 +++++++++++++++++++
>  MAINTAINERS                                   |  7 ++
>  2 files changed, 90 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/iio/accel/adi,adxl380.yaml
> 
> diff --git a/Documentation/devicetree/bindings/iio/accel/adi,adxl380.yaml b/Documentation/devicetree/bindings/iio/accel/adi,adxl380.yaml
> new file mode 100644
> index 000000000000..992e2ab841e2
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/accel/adi,adxl380.yaml
> @@ -0,0 +1,83 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/iio/accel/adi,adxl380.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Analog Devices ADXL380/382 3-Axis Digital Accelerometer
> +
> +maintainers:
> +  - Ramona Gradinariu <ramona.gradinariu@...log.com>
> +  - Antoniu Miclaus <antoniu.miclaus@...log.com>
> +
> +description: |
> +  The ADXL380/ADXL382 is a low noise density, low power, 3-axis
> +  accelerometer with selectable measurement ranges. The ADXL380
> +  supports the ±4 g, ±8 g, and ±16 g ranges, and the ADXL382 supports
> +  ±15 g, ±30 g, and ±60 g ranges.
> +  The ADXL380/ADXL382 offers industry leading noise, enabling precision
> +  applications with minimal calibration. The low noise, and low power
> +  ADXL380/ADXL382 enables accurate measurement in an environment with
> +  high vibration, heart sounds and audio.
> +
> +  In addition to its low power consumption, the ADXL380/ADXL382 has
> +  many features to enable true system level performance. These
> +  include a built-in micropower temperature sensor, single / double /
> +  triple tap detection and a state machine to prevent a false
> +  triggering. In addition, the ADXL380/ADXL382 has provisions for
> +  external control of the sampling time and/or an external clock.
> +
> +    https://www.analog.com/en/products/adxl380.html
> +
> +properties:
> +  compatible:
> +    enum:
> +      - adi,adxl380
> +      - adi,adxl382
> +
> +  reg:
> +    maxItems: 1
> +
> +  interrupts:
> +    maxItems: 1

Picture in the datasheet has 2.  If that's wrong note that for now and
remember to come back and update the comment when a real datasheet
becomes available.

> +
> +required:
> +  - compatible
> +  - reg
> +  - interrupts
No power? Magic device :)

In all seriousness, I want all new bindings for IIO devices at least to
include the power supplies they require to operate and make them required
properties.
That datasheet is less than informative "Preliminary Data sheet", but it
does mention a few in the text. vsupply and vddio


> +
> +allOf:
> +  - $ref: /schemas/spi/spi-peripheral-props.yaml#
> +
> +unevaluatedProperties: false
> +
> +examples:
> +  - |
> +    #include <dt-bindings/interrupt-controller/irq.h>
> +
> +    i2c {
> +      #address-cells = <1>;
> +      #size-cells = <0>;
> +
> +      accelerometer@54 {
> +        compatible = "adi,adxl380";
> +        reg = <0x54>;
> +        interrupt-parent = <&gpio>;
> +        interrupts = <25 IRQ_TYPE_LEVEL_HIGH>;
> +      };
> +    };
> +  - |
> +    #include <dt-bindings/interrupt-controller/irq.h>
> +
> +    spi {
> +      #address-cells = <1>;
> +      #size-cells = <0>;
> +
> +      accelerometer@0 {
> +        compatible = "adi,adxl380";
> +        reg = <0>;
> +        spi-max-frequency = <8000000>;
> +        interrupt-parent = <&gpio>;
> +        interrupts = <25 IRQ_TYPE_LEVEL_HIGH>;
> +      };
> +    };
> diff --git a/MAINTAINERS b/MAINTAINERS
> index be590c462d91..1425182c85e2 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -618,6 +618,13 @@ F:	drivers/iio/accel/adxl372.c
>  F:	drivers/iio/accel/adxl372_i2c.c
>  F:	drivers/iio/accel/adxl372_spi.c
>  
> +ADXL380 THREE-AXIS DIGITAL ACCELEROMETER DRIVER
> +M:	Ramona Gradinariu <ramona.gradinariu@...log.com>
> +M:	Antoniu Miclaus <antoniu.miclaus@...log.com>
> +S:	Supported
> +W:	https://ez.analog.com/linux-software-drivers
> +F:	Documentation/devicetree/bindings/iio/accel/adi,adxl380.yaml
> +
>  AF8133J THREE-AXIS MAGNETOMETER DRIVER
>  M:	Ondřej Jirman <megi@....cz>
>  S:	Maintained