linux-kernel - Re: [PATCH] arm64: dts: rockchip: Fix the i2c address of es8316 on Cool Pi 4B

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2771372.9AS07kTVam@bagend>
Date: Sun, 23 Jun 2024 13:31:02 +0200
From: Diederik de Haas <didi.debian@...ow.org>
To: heiko@...ech.de, linux-rockchip@...ts.infradead.org
Cc: dsimic@...jaro.org, devicetree@...r.kernel.org,
 linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
 linux-rockchip@...ts.infradead.org, Andy Yan <andyshrk@....com>,
 Andy Yan <andyshrk@....com>
Subject:
 Re: [PATCH] arm64: dts: rockchip: Fix the i2c address of es8316 on Cool Pi 4B

On Sunday, 23 June 2024 10:34:13 CEST Andy Yan wrote:
> According to the hardware design, the i2c address of audio codec es8316
> on Cool Pi 4B is 0x10.
> 
> ...
> ---
> 
>  arch/arm64/boot/dts/rockchip/rk3588s-coolpi-4b.dts | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/rockchip/rk3588s-coolpi-4b.dts
> b/arch/arm64/boot/dts/rockchip/rk3588s-coolpi-4b.dts index
> 20a0a60acd16..091dee37d068 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3588s-coolpi-4b.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3588s-coolpi-4b.dts
> @@ -302,7 +302,7 @@ &i2c7 {
> 
>  	es8316: audio-codec@11 {

Shouldn't this be `@10` then too?

>  		compatible = "everest,es8316";
> -		reg = <0x11>;
> +		reg = <0x10>;
>  		assigned-clocks = <&cru I2S0_8CH_MCLKOUT>;
>  		assigned-clock-rates = <12288000>;
>  		clocks = <&cru I2S0_8CH_MCLKOUT>;


Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)