[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-ID: <20240623122447.35847-3-yskelg@gmail.com>
Date: Sun, 23 Jun 2024 21:24:49 +0900
From: yskelg@...il.com
To: Harald Freudenberger <freude@...ux.ibm.com>,
Heiko Carstens <hca@...ux.ibm.com>,
Vasily Gorbik <gor@...ux.ibm.com>,
Alexander Gordeev <agordeev@...ux.ibm.com>,
Christian Borntraeger <borntraeger@...ux.ibm.com>,
Sven Schnelle <svens@...ux.ibm.com>
Cc: shjy180909@...il.com,
linux-s390@...r.kernel.org,
linux-kernel@...r.kernel.org,
Yunseong Kim <yskelg@...il.com>
Subject: [PATCH] s390/raw3270: handle memory allocation failure in 'raw3270_setup_console()'
From: Yunseong Kim <yskelg@...il.com>
This patch handle potential null pointer dereference in
'raw3270_setup_device()', When 'raw3270_setup_console()' fails to
allocate memory for 'rp' or 'ascebc'.
Signed-off-by: Yunseong Kim <yskelg@...il.com>
---
drivers/s390/char/raw3270.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/drivers/s390/char/raw3270.c b/drivers/s390/char/raw3270.c
index c57694be9bd3..4e81040eea81 100644
--- a/drivers/s390/char/raw3270.c
+++ b/drivers/s390/char/raw3270.c
@@ -812,7 +812,13 @@ struct raw3270 __init *raw3270_setup_console(void)
return ERR_CAST(cdev);
rp = kzalloc(sizeof(*rp), GFP_KERNEL | GFP_DMA);
+ if (!rp)
+ return ERR_PTR(-ENOMEM);
ascebc = kzalloc(256, GFP_KERNEL);
+ if (!ascebc) {
+ kfree(rp);
+ return ERR_PTR(-ENOMEM);
+ }
rc = raw3270_setup_device(cdev, rp, ascebc);
if (rc)
return ERR_PTR(rc);
--
2.45.2
Powered by blists - more mailing lists