linux-kernel - Re: [PATCH 3/8] iio: add child nodes support in iio backend framework

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240623145920.462d2fdb@jic23-huawei>
Date: Sun, 23 Jun 2024 14:59:20 +0100
From: Jonathan Cameron <jic23@...nel.org>
To: Olivier Moysan <olivier.moysan@...s.st.com>
Cc: Nuno Sa <nuno.sa@...log.com>, Lars-Peter Clausen <lars@...afoo.de>,
 <linux-iio@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 3/8] iio: add child nodes support in iio backend
 framework

On Tue, 18 Jun 2024 18:08:29 +0200
Olivier Moysan <olivier.moysan@...s.st.com> wrote:

> Add an API to support IIO generic channels binding:
> http://devicetree.org/schemas/iio/adc/adc.yaml#
> This new API is needed, as generic channel DT node
> isn't populated as a device.
> Add devm_iio_backend_subnode_get() to allow an IIO device
> backend consumer to configure backend phandles in its
> child nodes.

Really trivial stuff:

Don't wrap so far below 75 chars that is typical limit
for commit messages.

> 
> Signed-off-by: Olivier Moysan <olivier.moysan@...s.st.com>

> +
> +/**
> + * devm_iio_backend_get - Device managed backend device get
> + * @dev: Consumer device for the backend
> + * @name: Backend name
> + *
> + * Get's the backend associated with @dev.
> + *
> + * RETURNS:
> + * A backend pointer, negative error pointer otherwise.
> + */
> +struct iio_backend *devm_iio_backend_get(struct device *dev, const char *name)
> +{
> +	return __devm_iio_backend_node_get(dev, name, dev_fwnode(dev));
> +}
>  EXPORT_SYMBOL_NS_GPL(devm_iio_backend_get, IIO_BACKEND);
>  
> +/**
> + * devm_iio_backend_subnode_get - Device managed backend device get

Same short description as the one above.  Fairly sure this wants to be different!

> + * @dev: Consumer device for the backend
> + * @name: Backend name
> + * @node: Firmware node of the backend consumer
> + *
> + * Get's the backend associated with @dev.
> + *
> + * RETURNS:
> + * A backend pointer, negative error pointer otherwise.
> + */
> +struct iio_backend *devm_iio_backend_subnode_get(struct device *dev, const char *name,
> +						 struct fwnode_handle *node)
> +{
> +	return __devm_iio_backend_node_get(dev, name, node);
> +}
> +EXPORT_SYMBOL_NS_GPL(devm_iio_backend_subnode_get, IIO_BACKEND);