linux-kernel - [tip: irq/core] irqchip/renesas-rzg2l: Reorder function calls in rzg2l_irqc_irq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Sun, 23 Jun 2024 15:30:29 -0000
From: "tip-bot2 for Lad Prabhakar" <tip-bot2@...utronix.de>
To: linux-tip-commits@...r.kernel.org
Cc: Geert Uytterhoeven <geert+renesas@...der.be>,
 Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>,
 Thomas Gleixner <tglx@...utronix.de>,
 Claudiu Beznea <claudiu.beznea.uj@...renesas.com>, x86@...nel.org,
 linux-kernel@...r.kernel.org, maz@...nel.org
Subject: [tip: irq/core] irqchip/renesas-rzg2l: Reorder function calls in
 rzg2l_irqc_irq_disable()

The following commit has been merged into the irq/core branch of tip:

Commit-ID:     492eee82574b163fbb3f099c74ce3b4322d0af28
Gitweb:        https://git.kernel.org/tip/492eee82574b163fbb3f099c74ce3b4322d0af28
Author:        Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>
AuthorDate:    Thu, 06 Jun 2024 20:48:13 +01:00
Committer:     Thomas Gleixner <tglx@...utronix.de>
CommitterDate: Sun, 23 Jun 2024 17:23:08 +02:00

irqchip/renesas-rzg2l: Reorder function calls in rzg2l_irqc_irq_disable()

The order of function calls in the disable operation should be the reverse
of that in the enable operation. Thus, reorder the function calls to first
disable the parent IRQ chip before disabling the TINT IRQ.

Reported-by: Geert Uytterhoeven <geert+renesas@...der.be>
Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>
Signed-off-by: Thomas Gleixner <tglx@...utronix.de>
Tested-by: Claudiu Beznea <claudiu.beznea.uj@...renesas.com> # on RZ/G3S
Link: https://lore.kernel.org/r/20240606194813.676823-1-prabhakar.mahadev-lad.rj@bp.renesas.com

---
 drivers/irqchip/irq-renesas-rzg2l.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/irqchip/irq-renesas-rzg2l.c b/drivers/irqchip/irq-renesas-rzg2l.c
index 861a0e5..693ff28 100644
--- a/drivers/irqchip/irq-renesas-rzg2l.c
+++ b/drivers/irqchip/irq-renesas-rzg2l.c
@@ -271,8 +271,8 @@ static void rzg2l_tint_irq_endisable(struct irq_data *d, bool enable)
 
 static void rzg2l_irqc_irq_disable(struct irq_data *d)
 {
-	rzg2l_tint_irq_endisable(d, false);
 	irq_chip_disable_parent(d);
+	rzg2l_tint_irq_endisable(d, false);
 }
 
 static void rzg2l_irqc_irq_enable(struct irq_data *d)