linux-kernel - Re: [PATCH v3] drm/panel: raydium-rm692e5: transition to mipi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Sun, 23 Jun 2024 18:08:14 +0200
From: neil.armstrong@...aro.org
To: Doug Anderson <dianders@...omium.org>,
 Tejas Vipin <tejasvipin76@...il.com>
Cc: quic_jesszhan@...cinc.com, maarten.lankhorst@...ux.intel.com,
 mripard@...nel.org, tzimmermann@...e.de, airlied@...il.com, daniel@...ll.ch,
 dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3] drm/panel: raydium-rm692e5: transition to mipi_dsi
 wrapped functions

On 20/06/2024 21:18, Doug Anderson wrote:
> Hi,
> 
> On Thu, Jun 20, 2024 at 11:12 AM Tejas Vipin <tejasvipin76@...il.com> wrote:
>>
>> Use functions introduced in commit 966e397e4f60 ("drm/mipi-dsi:
>> Introduce mipi_dsi_*_write_seq_multi()") and commit f79d6d28d8fe
>> ("drm/mipi-dsi: wrap more functions for streamline handling") for the
>> raydium-rm692e5 panel.
>>
>> Additionally, the error handling in rm692e5_prepare() is changed to
>> properly power the panel off in the case of a wider range of
>> initialization commands failing than before.
>>
>> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
>> Reviewed-by: Douglas Anderson <dianders@...omium.org>
>> Signed-off-by: Tejas Vipin <tejasvipin76@...il.com>
>> ---
>> Changes in v3:
>>      - Remove extra blank line
>>      - Expanded on error handling functionality in patch notes
>>
>> Changes in v2:
>>      - Change rm692e5_on to return void and take mipi_dsi_multi_context
>>        as an argument.
>>      - Remove unnecessary warnings.
>>      - More efficient error handling in rm692e5_prepare
>>
>> v1: https://lore.kernel.org/all/20240615093758.65431-1-tejasvipin76@gmail.com/
>>
>> v2: https://lore.kernel.org/all/20240619033351.230929-1-tejasvipin76@gmail.com/
>> ---
>>   drivers/gpu/drm/panel/panel-raydium-rm692e5.c | 238 ++++++++----------
>>   1 file changed, 99 insertions(+), 139 deletions(-)
> 
> Thanks! I normally let non-urgent things sit for a week or so before
> applying them, but I'll be on vacation for some of next week and the
> one after. If this is still pending when I get back then I'll try to
> apply it as I'm getting through my inbox, though I'd also be happy if
> someone else (maybe Neil?) wanted to apply it next week.

Enjoy your vacations! I'll handle it.

Thanks,
Neil

> 
> -Doug