linux-kernel - Re: [PATCH 1/3] power: supply: ab8500: Fix error handling when calling iio_read_channel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240623181654.3fe94bbf@jic23-huawei>
Date: Sun, 23 Jun 2024 18:16:54 +0100
From: Jonathan Cameron <jic23@...nel.org>
To: Christophe JAILLET <christophe.jaillet@...adoo.fr>
Cc: linus.walleij@...aro.org, sre@...nel.org, linux-pm@...r.kernel.org,
 linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH 1/3] power: supply: ab8500: Fix error handling when
 calling iio_read_channel_processed()

On Sat, 22 Jun 2024 09:04:24 +0200
Christophe JAILLET <christophe.jaillet@...adoo.fr> wrote:

> The ab8500_charger_get_[ac|vbus]_[current|voltage]() functions should
> return an error code on error.
> 
> Up to now, an un-initialized value is returned.
> This makes the error handling of the callers un-reliable.
> 
> Return the error code instead, to fix the issue.
> 
> Fixes: 97ab78bac5d0 ("power: supply: ab8500_charger: Convert to IIO ADC")
> Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr>
Looks right to me.
Reviewed-by: Jonathan Cameron <Jonathan.Cameron@...wei.com>