linux-kernel - Re: [PATCH] sched_ext: Make scx_bpf_cpuperf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Sun, 23 Jun 2024 07:54:02 -1000
From: Tejun Heo <tj@...nel.org>
To: David Vernet <void@...ifault.com>
Cc: linux-kernel@...r.kernel.org, kernel-team@...a.com
Subject: Re: [PATCH] sched_ext: Make scx_bpf_cpuperf_set() @cpu arg signed

On Sun, Jun 23, 2024 at 03:10:36AM -0500, David Vernet wrote:
> The scx_bpf_cpuperf_set() kfunc allows a BPF program to set the relative
> performance target of a specified CPU. Commit d86adb4fc065 ("sched_ext: Add
> cpuperf support") defined the @cpu argument to be unsigned. Let's update it
> to be signed to match the norm for the rest of ext.c and the kernel.
> 
> Note that the kfunc declaration of scx_bpf_cpuperf_set() in the
> common.bpf.h header in tools/sched_ext already listed the cpu as signed, so
> this also fixes the build for tools/sched_ext and the sched_ext selftests
> due to kfunc declarations now being emitted in vmlinux.h based on BTF (thus
> causing the compiler to error due to observing conflicting types).
> 
> Fixes: d86adb4fc065 ("sched_ext: Add cpuperf support")
> Signed-off-by: David Vernet <void@...ifault.com>

Applied to sched_ext/for-6.11.

Thanks.

-- 
tejun