linux-kernel - Re: [PATCH v4 02/10] drm/bridge: add common api for inno hdmi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Sun, 23 Jun 2024 20:42:36 +0200
From: Markus Elfring <Markus.Elfring@....de>
To: Keith Zhao <keith.zhao@...rfivetech.com>,
 dri-devel@...ts.freedesktop.org, devicetree@...r.kernel.org,
 linux-arm-kernel@...ts.infradead.org, Andrzej Hajda
 <andrzej.hajda@...el.com>, Andy Yan <andy.yan@...k-chips.com>,
 Conor Dooley <conor+dt@...nel.org>, Daniel Vetter <daniel@...ll.ch>,
 David Airlie <airlied@...il.com>, Heiko Stübner
 <heiko@...ech.de>, Jack Zhu <jack.zhu@...rfivetech.com>,
 Jernej Skrabec <jernej.skrabec@...il.com>, Jonas Karlman <jonas@...boo.se>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Laurent Pinchart <laurent.pinchart@...asonboard.com>,
 Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
 Maxime Ripard <mripard@...nel.org>,
 Neil Armstrong <neil.armstrong@...aro.org>,
 Philipp Zabel <p.zabel@...gutronix.de>, Robert Foss <rfoss@...nel.org>,
 Rob Herring <robh@...nel.org>, Sandy Huang <hjc@...k-chips.com>,
 Shengyang Chen <shengyang.chen@...rfivetech.com>,
 Thomas Zimmermann <tzimmermann@...e.de>,
 Xingyu Wu <xingyu.wu@...rfivetech.com>
Cc: LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v4 02/10] drm/bridge: add common api for inno hdmi

…
> Signed-off-by: keith <keith.zhao@...rfivetech.com>

Should the personal name be more unique
(according to the Developer's Certificate of Origin)?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.10-rc4#n438


…
> +++ b/drivers/gpu/drm/bridge/innosilicon/inno-hdmi.c
> @@ -0,0 +1,587 @@
…
> +static int inno_hdmi_i2c_xfer(struct i2c_adapter *adap,
> +			      struct i2c_msg *msgs, int num)
> +{
…
> +	mutex_lock(&i2c->lock);
> +
> +	/* Clear the EDID interrupt flag and unmute the interrupt */
…
> +	hdmi_writeb(hdmi, HDMI_INTERRUPT_MASK1, 0);
> +
> +	mutex_unlock(&i2c->lock);
> +
> +	return ret;
> +}
…

Would you become interested to apply a statement like “guard(mutex)(&i2c->lock);”?
https://elixir.bootlin.com/linux/v6.10-rc4/source/include/linux/mutex.h#L196

Regards,
Markus