[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <2bo3yzeogfup2qfyeqrq2ini7g3evshteqpd5lxr6l5jupfo6w@tqwg2zuhlpph>
Date: Sun, 23 Jun 2024 23:54:35 +0300
From: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
To: Keith Zhao <keith.zhao@...rfivetech.com>
Cc: "andrzej.hajda@...el.com" <andrzej.hajda@...el.com>,
"neil.armstrong@...aro.org" <neil.armstrong@...aro.org>, "rfoss@...nel.org" <rfoss@...nel.org>,
"Laurent.pinchart@...asonboard.com" <Laurent.pinchart@...asonboard.com>, "jonas@...boo.se" <jonas@...boo.se>,
"jernej.skrabec@...il.com" <jernej.skrabec@...il.com>,
"maarten.lankhorst@...ux.intel.com" <maarten.lankhorst@...ux.intel.com>, "mripard@...nel.org" <mripard@...nel.org>,
"tzimmermann@...e.de" <tzimmermann@...e.de>, "airlied@...il.com" <airlied@...il.com>,
"daniel@...ll.ch" <daniel@...ll.ch>, "robh@...nel.org" <robh@...nel.org>,
"krzk+dt@...nel.org" <krzk+dt@...nel.org>, "conor+dt@...nel.org" <conor+dt@...nel.org>,
"hjc@...k-chips.com" <hjc@...k-chips.com>, "heiko@...ech.de" <heiko@...ech.de>,
"andy.yan@...k-chips.com" <andy.yan@...k-chips.com>, Xingyu Wu <xingyu.wu@...rfivetech.com>,
"p.zabel@...gutronix.de" <p.zabel@...gutronix.de>, Jack Zhu <jack.zhu@...rfivetech.com>,
Shengyang Chen <shengyang.chen@...rfivetech.com>,
"dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>, "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
"linux-arm-kernel@...ts.infradead.org" <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH v4 06/10] drm/vs: add vs plane api
On Sun, Jun 23, 2024 at 07:17:07AM GMT, Keith Zhao wrote:
> >
> > On Tue, May 21, 2024 at 06:58:13PM +0800, keith wrote:
> > > add plane funs and helper funs
> > > add vs drm common struct and funs
> > >
> > > Signed-off-by: keith <keith.zhao@...rfivetech.com>
> > > ---
> > > drivers/gpu/drm/verisilicon/Makefile | 3 +-
> > > drivers/gpu/drm/verisilicon/vs_drv.h | 93 +++++
> > > drivers/gpu/drm/verisilicon/vs_plane.c | 487
> > > +++++++++++++++++++++++++ drivers/gpu/drm/verisilicon/vs_plane.h |
> > > 26 ++
> > > 4 files changed, 608 insertions(+), 1 deletion(-) create mode 100644
> > > drivers/gpu/drm/verisilicon/vs_drv.h
> > > create mode 100644 drivers/gpu/drm/verisilicon/vs_plane.c
> > > create mode 100644 drivers/gpu/drm/verisilicon/vs_plane.h
> > > +
> > > +/*@...ch_alignment: buffer pitch alignment required by sub-devices.*/
> >
> > Is that all the docs you want to add?
> It should delete the redundant parts which is unused,
> To make this patch clearer to review
I'm sorry, I can't understand your comment.
> >
> > > +struct vs_drm_device {
> > > + struct drm_device base;
> > > + unsigned int pitch_alignment;
> > > + /* clocks */
> > > + unsigned int clk_count;
> > > + struct clk_bulk_data *clks;
> > > + struct reset_control *rsts;
> > > + struct vs_dc dc;
> > > + int irq;
> >
> > As usual, please drop unused fields and add them when required.
>
> In principle, I try to split the patch independently according to this.
> In fact, there is still a lot of room for optimization
> The subsequent patches will maintain independence and remove redundant parts for decoupling
Yes, please.
--
With best wishes
Dmitry
Powered by blists - more mailing lists