linux-kernel - Re: [PATCH] ASoC: dt-bindings: fsl,imx-audio-sgtl5000: Convert to dtschema

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Sun, 23 Jun 2024 09:08:29 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Animesh Agarwal <animeshagarwal28@...il.com>
Cc: Daniel Baluta <daniel.baluta@....com>, Liam Girdwood
 <lgirdwood@...il.com>, Mark Brown <broonie@...nel.org>,
 Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>, Shawn Guo <shawnguo@...nel.org>,
 Sascha Hauer <s.hauer@...gutronix.de>,
 Pengutronix Kernel Team <kernel@...gutronix.de>,
 Fabio Estevam <festevam@...il.com>, linux-sound@...r.kernel.org,
 devicetree@...r.kernel.org, imx@...ts.linux.dev,
 linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ASoC: dt-bindings: fsl,imx-audio-sgtl5000: Convert to
 dtschema

On 22/06/2024 20:21, Animesh Agarwal wrote:
> Convert the imx-audio-sgtl bindings to DT schema. Make bindings complete
> by adding audio-cpu property.

On what basis? Who needs or uses audio-cpu? Driver? DTS? Both? If only
DTS, then is it needed? Maybe not?

> 
> Signed-off-by: Animesh Agarwal <animeshagarwal28@...il.com>
> Cc: Daniel Baluta <daniel.baluta@....com>
> ---
>  .../sound/fsl,imx-audio-sgtl5000.yaml         | 108 ++++++++++++++++++
>  .../bindings/sound/imx-audio-sgtl5000.txt     |  56 ---------
>  2 files changed, 108 insertions(+), 56 deletions(-)
>  create mode 100644 Documentation/devicetree/bindings/sound/fsl,imx-audio-sgtl5000.yaml
>  delete mode 100644 Documentation/devicetree/bindings/sound/imx-audio-sgtl5000.txt
> 
> diff --git a/Documentation/devicetree/bindings/sound/fsl,imx-audio-sgtl5000.yaml b/Documentation/devicetree/bindings/sound/fsl,imx-audio-sgtl5000.yaml
> new file mode 100644
> index 000000000000..906dcecb73b7
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/sound/fsl,imx-audio-sgtl5000.yaml
> @@ -0,0 +1,108 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/sound/fsl,imx-audio-sgtl5000.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Freescale i.MX audio complex with SGTL5000 codec
> +
> +maintainers:
> +  - Animesh Agarwal <animeshagarwal28@...il.com>
> +
> +properties:
> +  compatible:
> +    oneOf:
> +      - items:
> +          - enum:
> +              - fsl,imx25-pdk-sgtl5000
> +              - fsl,imx51-babbage-sgtl5000
> +              - fsl,imx53-m53evk-sgtl5000
> +              - tq,imx53-mba53-sgtl5000
> +              - fsl,imx53-cpuvo-sgtl5000
> +              - fsl,imx53-qsb-sgtl5000
> +              - karo,tx53-audio-sgtl5000

Keep list ordered alphabetically.

> +              - fsl,imx53-voipac-sgtl5000
> +              - fsl,imx6q-ba16-sgtl5000
> +              - fsl,imx6q-ventana-sgtl5000
> +              - fsl,imx-sgtl5000
> +              - fsl,imx6-armadeus-sgtl5000
> +              - fsl,imx6dl-nit6xlite-sgtl5000
> +              - fsl,imx6q-nitrogen6_max-sgtl5000
> +              - fsl,imx6q-nitrogen6_som2-sgtl5000
> +              - fsl,imx6q-nitrogen6x-sgtl5000
> +              - fsl,imx6-rex-sgtl5000
> +              - fsl,imx6q-sabrelite-sgtl5000
> +              - fsl,imx6-wandboard-sgtl5000

None of these were in the old binding and commit msg mentions only
audio-cpu. From where do you get these?


> +          - const: fsl,imx-audio-sgtl5000
> +      - const: fsl,imx-audio-sgtl5000
> +
> +  model:
> +    $ref: /schemas/types.yaml#/definitions/string
> +    description: The user-visible name of this sound complex.
> +
> +  audio-cpu:
> +    $ref: /schemas/types.yaml#/definitions/phandle
> +    description: The phandle of an CPU DAI controller
> +
> +  ssi-controller:
> +    $ref: /schemas/types.yaml#/definitions/phandle
> +    description: The phandle of the i.MX SSI controller.
> +
> +  audio-codec:
> +    $ref: /schemas/types.yaml#/definitions/phandle
> +    description: The phandle of the SGTL5000 audio codec.
> +
> +  audio-routing:
> +    $ref: /schemas/types.yaml#/definitions/non-unique-string-array
> +    description: |
> +      A list of the connections between audio components. Each entry is a pair
> +      of strings, the first being the connection's sink, the second being the
> +      connection's source. Valid names could be:
> +
> +      Power supplies:
> +        * Mic Bias
> +
> +      SGTL5000 pins:
> +        * MIC_IN
> +        * LINE_IN
> +        * HP_OUT
> +        * LINE_OUT
> +
> +      Board connectors:
> +        * Mic Jack
> +        * Line In Jack
> +        * Headphone Jack
> +        * Line Out Jack
> +        * Ext Spk
> +
> +  mux-int-port:
> +    $ref: /schemas/types.yaml#/definitions/uint32
> +    description: The internal port of the i.MX audio muxer (AUDMUX).
> +    enum: [1, 2]

default:

> +
> +  mux-ext-port:
> +    $ref: /schemas/types.yaml#/definitions/uint32
> +    description: The external port of the i.MX audio muxer.
> +    enum: [3, 4, 5, 6]

defaukt:

> +
> +required:
> +  - compatible
> +  - model

Several other properties were required. Why changing this? Please
explain in commit msg all changes done to the binding comparing to pure
conversion.


Best regards,
Krzysztof