linux-kernel - Re: [PATCH] ASoC: dt-bindings: realtek,rt5659: Convert to dtschema

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <647b4d99-1c1e-41fa-929d-ffd6cda6584d@kernel.org>
Date: Sun, 23 Jun 2024 09:10:38 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Animesh Agarwal <animeshagarwal28@...il.com>
Cc: Daniel Baluta <daniel.baluta@....com>, Liam Girdwood
 <lgirdwood@...il.com>, Mark Brown <broonie@...nel.org>,
 Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>, linux-sound@...r.kernel.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ASoC: dt-bindings: realtek,rt5659: Convert to dtschema

On 22/06/2024 17:37, Animesh Agarwal wrote:
> Convert the RT5659/RT5658 audio CODEC bindings to DT schema.
> 
> Signed-off-by: Animesh Agarwal <animeshagarwal28@...il.com>
> Cc: Daniel Baluta <daniel.baluta@....com>


> +
> +allOf:
> +  - $ref: dai-common.yaml#
> +
> +properties:
> +  compatible:
> +    enum:
> +      - realtek,rt5659
> +      - realtek,rt5658
> +
> +  reg:
> +    maxItems: 1
> +    description: The I2C address of the device.

Drop description, redundant.

> +
> +  interrupts:
> +    maxItems: 1
> +    description: The CODEC's interrupt output.

Drop description, redundant.

> +
> +  clocks:
> +    maxItems: 1
> +    description: phandle and clock specifier for codec MCLK.

Drop description, redundant.

> +
> +  clock-names:
> +    const: mclk
> +
> +  realtek,dmic1-data-pin:
> +    $ref: /schemas/types.yaml#/definitions/uint32
> +    enum:
> +      - 0 # dmic1 is not used
> +      - 1 # using IN2N pin as dmic1 data pin
> +      - 2 # using GPIO5 pin as dmic1 data pin
> +      - 3 # using GPIO9 pin as dmic1 data pin
> +      - 4 # using GPIO11 pin as dmic1 data pin
> +    description: Specify which pin to be used as DMIC1 data pin.
> +
> +  realtek,dmic2-data-pin:
> +    $ref: /schemas/types.yaml#/definitions/uint32
> +    enum:
> +      - 0 # dmic1 is not used
> +      - 1 # using IN2P pin as dmic1 data pin
> +      - 2 # using GPIO6 pin as dmic1 data pin
> +      - 3 # using GPIO10 pin as dmic1 data pin
> +      - 4 # using GPIO12 pin as dmic1 data pin
> +    description: Specify which pin to be used as DMIC2 data pin.

default:

> +
> +  realtek,jd-src:
> +    $ref: /schemas/types.yaml#/definitions/uint32
> +    enum:
> +      - 0 # No JD is used
> +      - 1 # using JD3 as JD source
> +      - 2 # JD source for Intel HDA header
> +    description: Specify which JD source be used.

default:

> +
> +  realtek,ldo1-en-gpios:
> +    maxItems: 1
> +    description: The GPIO that controls the CODEC's LDO1_EN pin.

It's enough:
CODEC's LDO1_EN pin


> +
> +  realtek,reset-gpios:
> +    maxItems: 1
> +    description: The GPIO that controls the CODEC's RESET pin.
> +
> +  sound-name-prefix: true

Drop

> +
> +  ports:
> +    $ref: /schemas/graph.yaml#/properties/ports
> +
> +  port:
> +    $ref: audio-graph-port.yaml#
> +    unevaluatedProperties: false
> +
> +required:
> +  - compatible
> +  - reg
> +  - interrupts
> +
> +unevaluatedProperties: false
> +
> +examples:
> +  - |
> +    #include <dt-bindings/gpio/gpio.h>
> +    #include <dt-bindings/interrupt-controller/irq.h>
> +
> +    i2c {
> +        #address-cells = <1>;
> +        #size-cells = <0>;
> +
> +        codec@1b {
> +            compatible = "realtek,rt5659";
> +            reg = <0x1b>;
> +            interrupt-parent = <&gpio>;
> +            interrupts = <3 IRQ_TYPE_LEVEL_HIGH>;
> +            realtek,ldo1-en-gpios =
> +                <&gpio 3 GPIO_ACTIVE_HIGH>;

This can be one line.

Best regards,
Krzysztof