linux-kernel - Re: [REGRESSION] spi: omap2-mcspi: not working with kernel v6.10

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZnmXcNoPsPtjMuuF@louis-chauvet-laptop>
Date: Mon, 24 Jun 2024 17:57:36 +0200
From: Louis Chauvet <louis.chauvet@...tlin.com>
To: Linux regressions mailing list <regressions@...ts.linux.dev>
Cc: João Paulo Gonçalves <jpaulo.silvagoncalves@...il.com>,
	Mark Brown <broonie@...nel.org>,
	Vaishnav Achath <vaishnav.a@...com>, linux-spi@...r.kernel.org,
	linux-kernel@...r.kernel.org, joao.goncalves@...adex.com
Subject: Re: [REGRESSION] spi: omap2-mcspi: not working with kernel v6.10

Le 18/06/24 - 09:22, Linux regression tracking (Thorsten Leemhuis) a écrit :
> On 17.06.24 21:53, João Paulo Gonçalves wrote:
> > 
> > On Mon, Jun 17, 2024 at 11:29:05AM +0200, Thorsten Leemhuis wrote:
> >> In that case the thing that really
> >> helps would be if you could use a git bisection to find the change that
> >> causes this.
> > 
> > For me, spi stopped working in commit d153ff4056cb ("spi: omap2-mcspi:
> > Add support for MULTI-mode").
> 
> Hmmm, Louis (which already was in the CC) posted a patch with a Fixes:
> tag referencing that commit more than a month ago:
> 
> spi: omap2-mcspi: Ensure that CS is correctly asserted when switching
> from MULTI mode to SINGLE mode
> https://lore.kernel.org/all/20240506-fix-omap2-mcspi-v2-1-d9c77ba8b9c7@bootlin.com/
> 
> Unless I'm missing something, that patch did not make much progress
> since then. But I wonder if that might help. Louis? FWIW, this thread
> starts here with João problem description:
> https://lore.kernel.org/all/20240612170030.3qatttsgrwjg2m5s@joaog-nb/
> 
> Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker' hat)
> --
> Everything you wanna know about Linux kernel regression tracking:
> https://linux-regtracking.leemhuis.info/about/#tldr
> If I did something stupid, please tell me, as explained on that page.

Hello everyone,

First of all, sorry for the delay, I was sick last week.

Regarding the timeout problem, it is probably solved by [1], can you try 
this? I will send a v3 to apply Miquel's comments.

For the other problem (spi not asserted properly at the end of the 
message), I think I know how to solve it, I misunderstood the 
property cs_change (which doesn't have the same meaning for the last 
transfer). I will test it tomorrow and if it works I will send a patch.

Louis Chauvet

-- 
Louis Chauvet, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com