linux-kernel - Re: [PATCH] mailbox: mtk-cmdq: add missing MODULE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <df490024-440c-45aa-a420-312ad24a26e0@quicinc.com>
Date: Mon, 24 Jun 2024 09:09:37 -0700
From: Jeff Johnson <quic_jjohnson@...cinc.com>
To: AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>,
        Jassi Brar <jassisinghbrar@...il.com>,
        Matthias Brugger
	<matthias.bgg@...il.com>
CC: <linux-kernel@...r.kernel.org>, <linux-arm-kernel@...ts.infradead.org>,
        <linux-mediatek@...ts.infradead.org>,
        <kernel-janitors@...r.kernel.org>
Subject: Re: [PATCH] mailbox: mtk-cmdq: add missing MODULE_DESCRIPTION() macro

On 6/24/2024 4:34 AM, AngeloGioacchino Del Regno wrote:
> Il 08/06/24 18:31, Jeff Johnson ha scritto:
>> make allmodconfig && make W=1 C=1 reports:
>> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/mailbox/mtk-cmdq-mailbox.o
>>
>> Add the missing invocation of the MODULE_DESCRIPTION() macro.
>>
>> Signed-off-by: Jeff Johnson <quic_jjohnson@...cinc.com>
>> ---
>>   drivers/mailbox/mtk-cmdq-mailbox.c | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/mailbox/mtk-cmdq-mailbox.c b/drivers/mailbox/mtk-cmdq-mailbox.c
>> index 4aa394e91109..8247584bcbeb 100644
>> --- a/drivers/mailbox/mtk-cmdq-mailbox.c
>> +++ b/drivers/mailbox/mtk-cmdq-mailbox.c
>> @@ -790,4 +790,5 @@ static void __exit cmdq_drv_exit(void)
>>   subsys_initcall(cmdq_drv_init);
>>   module_exit(cmdq_drv_exit);
>>   
>> +MODULE_DESCRIPTION("Mediatek Command Queue(CMDQ) driver");
> 
> MODULE_DESCRIPTION("MediaTek Command Queue (CMDQ) Mailbox driver");
> 
> After which,
> 
> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>

ack, v2 coming