linux-kernel - Re: [PATCH] scsi: ufs: core: quiesce request queues before check pending cmds

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b1173b6f-445c-4d6d-9c78-b0351da2893a@acm.org>
Date: Mon, 24 Jun 2024 09:29:12 -0700
From: Bart Van Assche <bvanassche@....org>
To: Ziqi Chen <quic_ziqichen@...cinc.com>, quic_cang@...cinc.com,
 mani@...nel.org, beanhuo@...ron.com, avri.altman@....com,
 junwoo80.lee@...sung.com, martin.petersen@...cle.com,
 quic_nguyenb@...cinc.com, quic_nitirawa@...cinc.com,
 quic_rampraka@...cinc.com
Cc: linux-scsi@...r.kernel.org, Alim Akhtar <alim.akhtar@...sung.com>,
 "James E.J. Bottomley" <jejb@...ux.ibm.com>,
 Peter Wang <peter.wang@...iatek.com>,
 Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>,
 Maramaina Naresh <quic_mnaresh@...cinc.com>,
 Asutosh Das <quic_asutoshd@...cinc.com>,
 open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] scsi: ufs: core: quiesce request queues before check
 pending cmds

On 6/24/24 2:56 AM, Ziqi Chen wrote:
> 1. Why do we need to call blk_mq_quiesce_tagset() into 
> ufshcd_scsi_block_requests() instead directly replace all 
> ufshcd_scsi_block_requests() with blk_mq_quiesce_tagset()?

Because ufshcd_scsi_block_requests() has more callers than the clock
scaling code and because all callers of ufshcd_scsi_block_requests()
should be fixed.

> 2. This patch need to to do long-term stress test, I think many OEMs 
> can't wait as it is a blocker issue for them.
Patch "scsi: ufs: core: Quiesce request queues before checking pending
cmds" is already in Linus' master branch. I will rebase my patch on top
of linux-next.

Best regards,

Bart.