linux-kernel - Re: [PATCH] cpufreq: amd-pstate: Don't create attributes when registration fails

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87h6dj3qct.fsf@BLR-5CG11610CF.amd.com>
Date: Mon, 24 Jun 2024 10:10:50 +0530
From: Gautham R.Shenoy <gautham.shenoy@....com>
To: Mario Limonciello <mario.limonciello@....com>, <perry.yuan@....com>
CC: <linux-pm@...r.kernel.org>, <linux-kernel@...r.kernel.org>, "Mario
 Limonciello" <mario.limonciello@....com>, <alex.s.cochran@...ton.me>, "Peter
 Jung" <peterjung1337@...il.com>
Subject: Re: [PATCH] cpufreq: amd-pstate: Don't create attributes when
 registration fails

Mario Limonciello <mario.limonciello@....com> writes:

> If driver registration fails then immediately return the failure
> instead of continuing to register attributes.
>
> This fixes issues of falling back from amd-pstate to other drivers
> when cpufreq init has failed for any reason.
>
> Reported-by: alex.s.cochran@...ton.me
> Signed-off-by: Mario Limonciello <mario.limonciello@....com>

Thanks for fixing this.

Reviewed-by: Gautham R. Shenoy <gautham.shenoy@....com>

> ---
> Cc: Peter Jung <peterjung1337@...il.com>
>  drivers/cpufreq/amd-pstate.c | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c
> index 05e80d2f8803..7195dfa98cc5 100644
> --- a/drivers/cpufreq/amd-pstate.c
> +++ b/drivers/cpufreq/amd-pstate.c
> @@ -2030,8 +2030,10 @@ static int __init amd_pstate_init(void)
>  	}
>  
>  	ret = cpufreq_register_driver(current_pstate_driver);
> -	if (ret)
> +	if (ret) {
>  		pr_err("failed to register with return %d\n", ret);
> +		goto disable_driver;
> +	}
>  
>  	dev_root = bus_get_dev_root(&cpu_subsys);
>  	if (dev_root) {
> @@ -2047,6 +2049,8 @@ static int __init amd_pstate_init(void)
>  
>  global_attr_free:
>  	cpufreq_unregister_driver(current_pstate_driver);
> +disable_driver:
> +	amd_pstate_enable(false);
>  	return ret;
>  }
>  device_initcall(amd_pstate_init);
> -- 
> 2.43.0