[<prev] [next>] [day] [month] [year] [list]
Message-ID: <20240624175727.88012-2-thorsten.blum@toblux.com>
Date: Mon, 24 Jun 2024 19:57:28 +0200
From: Thorsten Blum <thorsten.blum@...lux.com>
To: elver@...gle.com,
dvyukov@...gle.com
Cc: kasan-dev@...glegroups.com,
linux-kernel@...r.kernel.org,
paulmck@...nel.org,
Thorsten Blum <thorsten.blum@...lux.com>
Subject: [PATCH v2] kcsan: Use min() to fix Coccinelle warning
Fixes the following Coccinelle/coccicheck warning reported by
minmax.cocci:
WARNING opportunity for min()
Use const size_t instead of int for the result of min().
Compile-tested with CONFIG_KCSAN=y.
Reviewed-by: Marco Elver <elver@...gle.com>
Signed-off-by: Thorsten Blum <thorsten.blum@...lux.com>
---
Changes in v2:
- Add const and remove redundant parentheses as suggested by Marco Elver
---
kernel/kcsan/debugfs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/kcsan/debugfs.c b/kernel/kcsan/debugfs.c
index 1d1d1b0e4248..53b21ae30e00 100644
--- a/kernel/kcsan/debugfs.c
+++ b/kernel/kcsan/debugfs.c
@@ -225,7 +225,7 @@ debugfs_write(struct file *file, const char __user *buf, size_t count, loff_t *o
{
char kbuf[KSYM_NAME_LEN];
char *arg;
- int read_len = count < (sizeof(kbuf) - 1) ? count : (sizeof(kbuf) - 1);
+ const size_t read_len = min(count, sizeof(kbuf) - 1);
if (copy_from_user(kbuf, buf, read_len))
return -EFAULT;
--
2.45.2
Powered by blists - more mailing lists