linux-kernel - Re: [tip:irq/core 41/49] drivers/irqchip/irq-dw-apb-ictl.c:33:25: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'dw_apb_ictl_handle

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Mon, 24 Jun 2024 20:40:42 +0200
From: Thomas Gleixner <tglx@...utronix.de>
To: kernel test robot <lkp@...el.com>, Jisheng Zhang <jszhang@...nel.org>
Cc: oe-kbuild-all@...ts.linux.dev, linux-kernel@...r.kernel.org, x86@...nel.org
Subject: Re: [tip:irq/core 41/49] drivers/irqchip/irq-dw-apb-ictl.c:33:25:
 error: expected '=', ',', ';', 'asm' or '__attribute__' before
 'dw_apb_ictl_handle_irq'

On Tue, Jun 25 2024 at 02:06, kernel test robot wrote:
> Hi Jisheng,
>
> First bad commit (maybe != root cause):
>
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git irq/core
> head:   f2605e1715dd28e8943b557453fed3a40421d3b5
> commit: 7cc4f309c933ec5d64eea31066fe86bbf9e48819 [41/49] irqchip/dw-apb-ictl: Support building as module
> config: i386-allmodconfig (https://download.01.org/0day-ci/archive/20240625/202406250214.WZEjWnnU-lkp@intel.com/config)
> compiler: gcc-13 (Ubuntu 13.2.0-4ubuntu3) 13.2.0
> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240625/202406250214.WZEjWnnU-lkp@intel.com/reproduce)
>
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@...el.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202406250214.WZEjWnnU-lkp@intel.com/
>
> All errors (new ones prefixed by >>):
>
>>> drivers/irqchip/irq-dw-apb-ictl.c:33:25: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'dw_apb_ictl_handle_irq'
>       33 | static void __irq_entry dw_apb_ictl_handle_irq(struct pt_regs *regs)
>          |                         ^~~~~~~~~~~~~~~~~~~~~~

That's because the drivers is now selectable via Kconfig, so
allmodconfig sets it to M and builds it which does not work on a x86
build unsurprisingly.

Jisheng, please send a delta fix ASAP. Otherwise I have to revert it.

Thanks,

        tglx