linux-kernel - Re: [etnaviv-next v14 0/8] drm/etnaviv: Add driver wrapper for vivante GPUs attached on PCI(e) device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Mon, 24 Jun 2024 20:47:39 +0200
From: Christian Gmeiner <christian.gmeiner@...il.com>
To: Sui Jingfeng <sui.jingfeng@...ux.dev>
Cc: Lucas Stach <l.stach@...gutronix.de>, Russell King <linux+etnaviv@...linux.org.uk>, 
	linux-kernel@...r.kernel.org, etnaviv@...ts.freedesktop.org, 
	dri-devel@...ts.freedesktop.org
Subject: Re: [etnaviv-next v14 0/8] drm/etnaviv: Add driver wrapper for
 vivante GPUs attached on PCI(e) device

Hi

>
> drm/etnaviv use the component framework to bind multiple GPU cores to a
> virtual master, the virtual master is manually create during driver load
> time. This works well for various SoCs, yet there are some PCIe card has
> the vivante GPU cores integrated. The driver lacks the support for PCIe
> devices currently.
>
> Adds PCIe driver wrapper on the top of what drm/etnaviv already has, the
> component framework is still being used to bind subdevices, even though
> there is only one GPU core. But the process is going to be reversed, we
> create virtual platform device for each of the vivante GPU IP core shipped
> by the PCIe master. The PCIe master is real, bind all the virtual child
> to the master with component framework.
>
>
> v6:
>         * Fix build issue on system without CONFIG_PCI enabled
> v7:
>         * Add a separate patch for the platform driver rearrangement (Bjorn)
>         * Switch to runtime check if the GPU is dma coherent or not (Lucas)
>         * Add ETNAVIV_PARAM_GPU_COHERENT to allow userspace to query (Lucas)
>         * Remove etnaviv_gpu.no_clk member (Lucas)
>         * Fix Various typos and coding style fixed (Bjorn)
> v8:
>         * Fix typos and remove unnecessary header included (Bjorn).
>         * Add a dedicated function to create the virtual master platform
>           device.
> v9:
>         * Use PCI_VDEVICE() macro (Bjorn)
>         * Add trivial stubs for the PCI driver (Bjorn)
>         * Remove a redundant dev_err() usage (Bjorn)
>         * Clean up etnaviv_pdev_probe() with etnaviv_of_first_available_node()
> v10:
>         * Add one more cleanup patch
>         * Resolve the conflict with a patch from Rob
>         * Make the dummy PCI stub inlined
>         * Print only if the platform is dma-coherrent
> V11:
>         * Drop unnecessary changes (Lucas)
>         * Tweak according to other reviews of v10.
>
> V12:
>         * Create a virtual platform device for the subcomponent GPU cores
>         * Bind all subordinate GPU cores to the real PCI master via component.
>
> V13:
>         * Drop the non-component code path, always use the component framework
>           to bind subcomponent GPU core. Even though there is only one core.
>         * Defer the irq handler register.
>         * Rebase and improve the commit message
>
> V14:
>         * Rebase onto etnaviv-next and improve commit message.
>
> Tested with JD9230P GPU and LingJiu GP102 GPU.
>

I was able to test this series and will do a review in the next few
days. Hopefully this series will land anytime.

[    6.783267] etnaviv 0000:0c:00.0: enabling device (0000 -> 0003)
[    6.783324] etnaviv 0000:0c:00.0: JingJia Micro JM9100 has 1 GPU cores
[    6.783459] etnaviv 0000:0c:00.0: bound etnaviv-gpu,3d.0 (ops
gpu_ops [etnaviv])
[    6.783502] etnaviv-gpu etnaviv-gpu,3d.0: model: GC9200, revision: 6304
[    6.783635] [drm] Initialized etnaviv 1.4.0 20151214 for
0000:0c:00.0 on minor 1

Tested-by: Christian Gmeiner <cgmeiner@...lia.com>


> Sui Jingfeng (8):
>   drm/etnaviv: Add a dedicated helper function to get various clocks
>   drm/etnaviv: Add constructor and destructor for the
>     etnaviv_drm_private structure
>   drm/etnaviv: Embed struct drm_device into struct etnaviv_drm_private
>   drm/etnaviv: Fix wrong cache property being used for vmap()
>   drm/etnaviv: Add support for cached coherent caching mode
>   drm/etnaviv: Replace the '&pdev->dev' with 'dev'
>   drm/etnaviv: Allow creating subdevices and pass platform specific data
>   drm/etnaviv: Add support for vivante GPU cores attached via PCIe
>     device
>
>  drivers/gpu/drm/etnaviv/Kconfig              |   8 +
>  drivers/gpu/drm/etnaviv/Makefile             |   2 +
>  drivers/gpu/drm/etnaviv/etnaviv_drv.c        | 159 ++++++++++------
>  drivers/gpu/drm/etnaviv/etnaviv_drv.h        |  27 +++
>  drivers/gpu/drm/etnaviv/etnaviv_gem.c        |  22 ++-
>  drivers/gpu/drm/etnaviv/etnaviv_gem_submit.c |   2 +-
>  drivers/gpu/drm/etnaviv/etnaviv_gpu.c        | 144 +++++++++-----
>  drivers/gpu/drm/etnaviv/etnaviv_gpu.h        |   4 +
>  drivers/gpu/drm/etnaviv/etnaviv_mmu.c        |   4 +-
>  drivers/gpu/drm/etnaviv/etnaviv_pci_drv.c    | 187 +++++++++++++++++++
>  drivers/gpu/drm/etnaviv/etnaviv_pci_drv.h    |  18 ++
>  include/uapi/drm/etnaviv_drm.h               |   1 +
>  12 files changed, 468 insertions(+), 110 deletions(-)
>  create mode 100644 drivers/gpu/drm/etnaviv/etnaviv_pci_drv.c
>  create mode 100644 drivers/gpu/drm/etnaviv/etnaviv_pci_drv.h
>
>
> base-commit: 52272bfff15ee70c7bd5be9368f175948fb8ecfd
> --
> 2.34.1
>


-- 
greets
--
Christian Gmeiner, MSc

https://christian-gmeiner.info/privacypolicy