linux-kernel - Re: [PATCH] drm/amd/display: Check pipe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Mon, 24 Jun 2024 21:26:50 +0200
From: Markus Elfring <Markus.Elfring@....de>
To: Ma Ke <make24@...as.ac.cn>, amd-gfx@...ts.freedesktop.org,
 dri-devel@...ts.freedesktop.org, Alex Deucher <alexander.deucher@....com>,
 Alex Hung <alex.hung@....com>, Alvin Lee <Alvin.Lee2@....com>,
 Christian König <christian.koenig@....com>,
 Daniel Vetter <daniel@...ll.ch>, David Airlie <airlied@...il.com>,
 Dillon Varone <dillon.varone@....com>, George Shen <george.shen@....com>,
 Hamza Mahfooz <hamza.mahfooz@....com>,
 Harry Wentland <harry.wentland@....com>, Jun Lei <jun.lei@....com>,
 Leo Li <sunpeng.li@....com>, Rodrigo Siqueira <Rodrigo.Siqueira@....com>,
 Wenjing Liu <wenjing.liu@....com>, Xinhui Pan <Xinhui.Pan@....com>
Cc: LKML <linux-kernel@...r.kernel.org>,
 Aurabindo Pillai <aurabindo.pillai@....com>, Hersen Wu
 <hersenxs.wu@....com>, Natanel Roizenman <natanel.roizenman@....com>,
 Nicholas Kazlauskas <nicholas.kazlauskas@....com>,
 Tom Chung <chiahsuan.chung@....com>
Subject: Re: [PATCH] drm/amd/display: Check pipe_ctx before it is used

>> resource_get_otg_master_for_stream() could return NULL, we
>> should check the return value of 'otg_master' before it is
>> used in resource_log_pipe_for_stream().
>
> A similar fix was integrated already according to a contribution
> by Natanel Roizenman.
> From which Linux version did you take source files for your static code analyses?
>
> Please take another look at the corresponding software update.
> [PATCH 16/37] drm/amd/display: Add null check in resource_log_pipe_topology_update
> https://lore.kernel.org/amd-gfx/20240422152817.2765349-17-aurabindo.pillai@amd.com/

How “interesting” is it that a similar source code correction needed
to be repeated by Hersen Wu?

drm/amd/display: Add otg_master NULL check within resource_log_pipe_topology_update
https://lore.kernel.org/amd-gfx/20240501071651.3541919-31-chiahsuan.chung@amd.com/

Regards,
Markus