linux-kernel - Re: [PATCH 0/3] spi: add devm_spi_optimize

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240624204332.7cb1243a@jic23-huawei>
Date: Mon, 24 Jun 2024 20:43:32 +0100
From: Jonathan Cameron <jic23@...nel.org>
To: Mark Brown <broonie@...nel.org>
Cc: David Lechner <dlechner@...libre.com>, Michael Hennerich
 <michael.hennerich@...log.com>, Nuno Sá <nuno.sa@...log.com>,
 Marcelo Schmitt <marcelo.schmitt@...log.com>, Jonathan Corbet
 <corbet@....net>, linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-spi@...r.kernel.org, linux-iio@...r.kernel.org
Subject: Re: [PATCH 0/3] spi: add devm_spi_optimize_message() helper

On Mon, 24 Jun 2024 20:39:18 +0100
Jonathan Cameron <jic23@...nel.org> wrote:

> On Sun, 23 Jun 2024 18:20:39 +0100
> Mark Brown <broonie@...nel.org> wrote:
> 
> > On Fri, Jun 21, 2024 at 03:51:29PM -0500, David Lechner wrote:  
> > > In the IIO subsystem, we are finding that it is common to call
> > > spi_optimize_message() during driver probe since the SPI message
> > > doesn't change for the lifetime of the driver. This patch adds a
> > > devm_spi_optimize_message() helper to simplify this common pattern.    
> > 
> > The following changes since commit 6ba59ff4227927d3a8530fc2973b80e94b54d58f:
> > 
> >   Linux 6.10-rc4 (2024-06-16 13:40:16 -0700)
> > 
> > are available in the Git repository at:
> > 
> >   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git tags/spi-devm-optimize  
> 
> Thanks.  Applied patch 3 on a merge of that tag into the togreg branch
> of iio.git which I've pushed out as testing to see if anything went
> horribly wrong ;)
> 
Hit send too soon.  The new devm_spi_optmize_message() is missing an
EXPORT_SYMBOL_*  so my local build test with modules failed.

Jonathan

> Jonathan
> 
> > 
> > for you to fetch changes up to d4a0055fdc22381fa256e345095e88d134e354c5:
> > 
> >   spi: add devm_spi_optimize_message() helper (2024-06-22 12:14:33 +0100)
> > 
> > ----------------------------------------------------------------
> > spi: add devm_spi_optimize_message() helper
> > 
> > Helper from David Lechner <dlechner@...libre.com>:
> > 
> >     In the IIO subsystem, we are finding that it is common to call
> >     spi_optimize_message() during driver probe since the SPI message
> >     doesn't change for the lifetime of the driver. This patch adds a
> >     devm_spi_optimize_message() helper to simplify this common pattern.
> > 
> > ----------------------------------------------------------------
> > David Lechner (2):
> >       Documentation: devres: add missing SPI helpers
> >       spi: add devm_spi_optimize_message() helper
> > 
> >  Documentation/driver-api/driver-model/devres.rst |  3 +++
> >  drivers/spi/spi.c                                | 27 ++++++++++++++++++++++++
> >  include/linux/spi/spi.h                          |  2 ++
> >  3 files changed, 32 insertions(+)  
>