linux-kernel - Re: [PATCH 01/10] iio: adc: aspeed_adc: use devm_regulator_get_enable_read

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Mon, 24 Jun 2024 09:58:17 +0930
From: Andrew Jeffery <andrew@...econstruct.com.au>
To: David Lechner <dlechner@...libre.com>, Jonathan Cameron
 <jic23@...nel.org>
Cc: Joel Stanley <joel@....id.au>, Liam Girdwood <lgirdwood@...il.com>, Mark
 Brown <broonie@...nel.org>, Andreas Klinger <ak@...klinger.de>, Michael
 Hennerich <Michael.Hennerich@...log.com>, Nuno Sá
 <nuno.sa@...log.com>,  linux-iio@...r.kernel.org,
 linux-arm-kernel@...ts.infradead.org,  linux-aspeed@...ts.ozlabs.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH 01/10] iio: adc: aspeed_adc: use
 devm_regulator_get_enable_read_voltage()

On Fri, 2024-06-21 at 17:11 -0500, David Lechner wrote:
> This makes use of the devm_regulator_get_enable_read_voltage() helper
> function to simplify the code.
> 
> The error return is moved closer to the function call to make it easier
> to follow the logic. And a few blank lines are added for readability.
> 
> Signed-off-by: David Lechner <dlechner@...libre.com>

Nice cleanup!

Reviewed-by: Andrew Jeffery <andrew@...econstruct.com.au>