linux-kernel - Re: [PATCH v4 1/5] mm: add ARCH_SUPPORTS_NON_LEAF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <omqeaa2zv62avwaq7lg53siikp2aheonf3wc3anotmnh2hytx5@bdonyrfokmmx>
Date: Mon, 24 Jun 2024 17:27:12 -0500
From: Maxwell Bland <mbland@...orola.com>
To: LEROY Christophe <christophe.leroy2@...soprasteria.com>
Cc: Catalin Marinas <catalin.marinas@....com>, Will Deacon <will@...nel.org>,
        Jonathan Corbet <corbet@....net>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Ard Biesheuvel <ardb@...nel.org>, Mark Rutland <mark.rutland@....com>,
        Alexandre Ghiti <alexghiti@...osinc.com>,
        "linux-arm-kernel@...ts.infradead.org" <linux-arm-kernel@...ts.infradead.org>,
        "linux-doc@...r.kernel.org" <linux-doc@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v4 1/5] mm: add ARCH_SUPPORTS_NON_LEAF_PTDUMP

On Wed, Jun 19, 2024 at 08:44:21AM GMT, LEROY Christophe wrote:
> Le 18/06/2024 à 21:41, Maxwell Bland a écrit :
> > On Tue, Jun 18, 2024 at 06:38:24PM GMT, LEROY Christophe wrote:
> >> Le 18/06/2024 à 16:40, Maxwell Bland a écrit :
> >> Don't you mean pmd_leaf() here instead of pgd_leaf() ?
> > thank you for catching these, will fix in v5.
> 
> Maybe we could have a nicer code with something like:
> 
> static inline bool has_non_leaf_ptdump()
> {
> 	return IS_ENABLED(CONFIG_ARCH_SUPPORTS_NON_LEAF_PTDUMP);
> }
> 
> static int ptdump_p4d_entry(...)
> {
> 	...
> 	if (has_non_leaf_ptdump() || pgd_leaf(val))
> 		...
> }

Hi Christophe, nice, thank you! I incorporated this critique as well.

Forward pointer to v5:
https://lore.kernel.org/all/2bcb3htsjhepxdybpw2bwot2jnuezl3p5mnj5rhjwgitlsufe7@xzhkyntridw3/#t

Maxwell