linux-kernel - Re: [PATCH v9 net-next 14/15] net: Reference bpf_redirect_info via task_struct on PREEMPT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240624163707.1850c113@kernel.org>
Date: Mon, 24 Jun 2024 16:37:07 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Sebastian Andrzej Siewior <bigeasy@...utronix.de>
Cc: linux-kernel@...r.kernel.org, netdev@...r.kernel.org, "David S. Miller"
 <davem@...emloft.net>, Daniel Bristot de Oliveira <bristot@...nel.org>,
 Boqun Feng <boqun.feng@...il.com>, Daniel Borkmann <daniel@...earbox.net>,
 Eric Dumazet <edumazet@...gle.com>, Frederic Weisbecker
 <frederic@...nel.org>, Ingo Molnar <mingo@...hat.com>, Paolo Abeni
 <pabeni@...hat.com>, Peter Zijlstra <peterz@...radead.org>, Thomas Gleixner
 <tglx@...utronix.de>, Waiman Long <longman@...hat.com>, Will Deacon
 <will@...nel.org>, Alexei Starovoitov <ast@...nel.org>, Andrii Nakryiko
 <andrii@...nel.org>, Eduard Zingerman <eddyz87@...il.com>, Hao Luo
 <haoluo@...gle.com>, Jesper Dangaard Brouer <hawk@...nel.org>, Jiri Olsa
 <jolsa@...nel.org>, John Fastabend <john.fastabend@...il.com>, KP Singh
 <kpsingh@...nel.org>, Martin KaFai Lau <martin.lau@...ux.dev>, Song Liu
 <song@...nel.org>, Stanislav Fomichev <sdf@...gle.com>, Toke
 Høiland-Jørgensen <toke@...hat.com>, Yonghong Song
 <yonghong.song@...ux.dev>, bpf@...r.kernel.org
Subject: Re: [PATCH v9 net-next 14/15] net: Reference bpf_redirect_info via
 task_struct on PREEMPT_RT.

On Mon, 24 Jun 2024 09:26:11 +0200 Sebastian Andrzej Siewior wrote:
> > > +	p->bpf_net_context =  NULL;  
> > 
> > nit: double space after =
> > 
> > Out of curiosity, do we actually have to clear this pointer?  
> 
> I don't think so. We never clone a thread within a redirect section so
> this can probably go away.

Perhaps delete this one as follow up, too?