linux-kernel - Re: [PATCH] xen/manage: Constify struct shutdown

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <988f62b6-642d-404e-ae1e-1c9a428c1eb9@suse.com>
Date: Mon, 24 Jun 2024 08:34:48 +0200
From: Jürgen Groß <jgross@...e.com>
To: Christophe JAILLET <christophe.jaillet@...adoo.fr>,
 Stefano Stabellini <sstabellini@...nel.org>,
 Oleksandr Tyshchenko <oleksandr_tyshchenko@...m.com>
Cc: linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org,
 xen-devel@...ts.xenproject.org
Subject: Re: [PATCH] xen/manage: Constify struct shutdown_handler

On 23.06.24 11:26, Christophe JAILLET wrote:
> 'struct shutdown_handler' is not modified in this driver.
> 
> Constifying this structure moves some data to a read-only section, so
> increase overall security.
> 
> On a x86_64, with allmodconfig:
> Before:
> ======
>     text	   data	    bss	    dec	    hex	filename
>     7043	    788	      8	   7839	   1e9f	drivers/xen/manage.o
> 
> After:
> =====
>     text	   data	    bss	    dec	    hex	filename
>     7164	    676	      8	   7848	   1ea8	drivers/xen/manage.o
> 
> Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr>

Reviewed-by: Juergen Gross <jgross@...e.com>


Juergen