linux-kernel - Re: [PATCH] Bluetooth: hci: fix build when POWER

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Mon, 24 Jun 2024 08:53:18 +0200
From: Bartosz Golaszewski <bartosz.golaszewski@...aro.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Cc: Marcel Holtmann <marcel@...tmann.org>, Luiz Augusto von Dentz <luiz.dentz@...il.com>, 
	linux-bluetooth@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Bluetooth: hci: fix build when POWER_SEQUENCING=m

On Sun, 23 Jun 2024 at 19:13, Krzysztof Kozlowski
<krzysztof.kozlowski@...aro.org> wrote:
>
> BT_HCIUART_QCA, which is a bool and an HCI UART component, uses now
> power sequencing, so we need to be sure BT_HCIUART_QCA=y and
> POWER_SEQUENCING=m cannot happen:
>
>   /usr/bin/aarch64-linux-gnu-ld: drivers/bluetooth/hci_qca.o: in function `qca_serdev_probe':
>   drivers/bluetooth/hci_qca.c:2401:(.text+0xc48): undefined reference to `devm_pwrseq_get'
>   /usr/bin/aarch64-linux-gnu-ld: drivers/bluetooth/hci_qca.o: in function `qca_power_shutdown':
>   drivers/bluetooth/hci_qca.c:2192:(.text+0x29e8): undefined reference to `pwrseq_power_off'
>   /usr/bin/aarch64-linux-gnu-ld: drivers/bluetooth/hci_qca.o: in function `qca_power_on':
>   drivers/bluetooth/hci_qca.c:1808:(.text+0x3390): undefined reference to `pwrseq_power_on'
>
> Fixes: 4029dba6b6f1 ("Bluetooth: qca: use the power sequencer for QCA6390")
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> ---
>  drivers/bluetooth/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/bluetooth/Kconfig b/drivers/bluetooth/Kconfig
> index 87484f5de8e3..90a94a111e67 100644
> --- a/drivers/bluetooth/Kconfig
> +++ b/drivers/bluetooth/Kconfig
> @@ -105,6 +105,7 @@ config BT_HCIUART
>         tristate "HCI UART driver"
>         depends on SERIAL_DEV_BUS || !SERIAL_DEV_BUS
>         depends on NVMEM || !NVMEM
> +       depends on POWER_SEQUENCING || !POWER_SEQUENCING
>         depends on TTY
>         help
>           Bluetooth HCI UART driver.
> --
> 2.43.0
>

Sorry for that. Here's[1] some more info on that Kconfig trick. Thanks
Krzysztof for bringing this to my attention.

Reviewed-by: Bartosz Golaszewski <bartosz.golaszewski@...aro.org>

[1] https://lwn.net/Articles/944368/