linux-kernel - Re: [PATCHv5 7/9] ASoC: dt-bindings: imx-audio-spdif: remove binding

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <42b32958-89ee-43b6-96d1-f3e18c7d8955@kernel.org>
Date: Mon, 24 Jun 2024 10:55:31 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Elinor Montmasson <elinor.montmasson@...oirfairelinux.com>
Cc: Liam Girdwood <lgirdwood@...il.com>, Mark Brown <broonie@...nel.org>,
 Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>, Shawn Guo <shawnguo@...nel.org>,
 Sascha Hauer <s.hauer@...gutronix.de>, Fabio Estevam <festevam@...il.com>,
 Russell King <linux@...linux.org.uk>,
 Catalin Marinas <catalin.marinas@....com>, Will Deacon <will@...nel.org>,
 Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.com>,
 shengjiu wang <shengjiu.wang@...il.com>, Xiubo Lee <Xiubo.Lee@...il.com>,
 Nicolin Chen <nicoleotsuka@...il.com>,
 Pengutronix Kernel Team <kernel@...gutronix.de>,
 linux-sound <linux-sound@...r.kernel.org>,
 devicetree <devicetree@...r.kernel.org>, imx <imx@...ts.linux.dev>,
 linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>,
 linux-kernel <linux-kernel@...r.kernel.org>,
 alsa-devel <alsa-devel@...a-project.org>,
 linuxppc-dev <linuxppc-dev@...ts.ozlabs.org>,
 Philip-Dylan Gleonec <philip-dylan.gleonec@...oirfairelinux.com>
Subject: Re: [PATCHv5 7/9] ASoC: dt-bindings: imx-audio-spdif: remove binding

On 24/06/2024 10:51, Elinor Montmasson wrote:
> From: "Krzysztof Kozlowski" <krzk@...nel.org>
> Sent: Sunday, 23 June, 2024 13:09:33
>> On 20/06/2024 15:25, Elinor Montmasson wrote:
>>> imx-audio-spdif was merged into the fsl-asoc-card driver, and therefore
>>> removed.
>>
>> So what happens with all existing users (e.g. DTS)? They become
>> invalid/not supported?
> 
> 
> Next commits, 8/9 and 9/9, update all DTS files that currently use
> the "fsl,imx-audio-spdif" compatible.

You mean in-tree. I mean all users, in- and out-of-tree. Other projects.

> From the users point of view, currently configured spdif audio cards
> will behave just the same.
> 
> 
>> After quick look, I do not see backwards compatibility in the driver and
>> above commit msg tells me nothing about ABI break.
> 
> 
> For the next version I will state in this commit message the upcoming modifications to DTS
> and compatibility, why it will be done, and that support for existing DTS is not dropped.
> 
> Previous `imx-spdif` driver used the dummy codec instead of
> using declared spdif codecs. It was discussed in previous version of this contribution
> that using the dummy codec isn't good practice. So one to one backward compatibility
> isn't really possible.

Heh, that's not good. This is improvement, cleanup. While it is
important and useful, it should also not break existing users.

Best regards,
Krzysztof