linux-kernel - Re: [PATCH v2 4/5] dt-bindings: net: wireless: brcm4329-fmac: add clock description.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5b845bad-45b9-4cbb-8d51-b4efd1a4cd3c@broadcom.com>
Date: Mon, 24 Jun 2024 10:59:44 +0200
From: Arend van Spriel <arend.vanspriel@...adcom.com>
To: Jacobe Zang <jacobe.zang@...ion.com>
Cc: kvalo@...nel.org, duoming@....edu.cn, bhelgaas@...gle.com,
 minipli@...ecurity.net, linux-wireless@...r.kernel.org,
 brcm80211@...ts.linux.dev, brcm80211-dev-list.pdl@...adcom.com, megi@....cz,
 robh@...nel.org, efectn@...tonmail.com, krzk+dt@...nel.org,
 conor+dt@...nel.org, heiko@...ech.de, nick@...das.com, jagan@...eble.ai,
 dsimic@...jaro.org, devicetree@...r.kernel.org,
 linux-arm-kernel@...ts.infradead.org, linux-rockchip@...ts.infradead.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 4/5] dt-bindings: net: wireless: brcm4329-fmac: add
 clock description.

On 6/24/2024 10:19 AM, Jacobe Zang wrote:
> Add clocks and clock-names for brcm4329-fmac.

Thanks. Prefer another clock name though ...

> Signed-off-by: Jacobe Zang <jacobe.zang@...ion.com>
> ---
>   .../bindings/net/wireless/brcm,bcm4329-fmac.yaml         | 9 +++++++++
>   1 file changed, 9 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/net/wireless/brcm,bcm4329-fmac.yaml b/Documentation/devicetree/bindings/net/wireless/brcm,bcm4329-fmac.yaml
> index e564f20d8f415..b9e39a62c3b32 100644
> --- a/Documentation/devicetree/bindings/net/wireless/brcm,bcm4329-fmac.yaml
> +++ b/Documentation/devicetree/bindings/net/wireless/brcm,bcm4329-fmac.yaml
> @@ -121,6 +121,15 @@ properties:
>         NVRAM. This would normally be filled in by the bootloader from platform
>         configuration data.
>   
> +  clocks:
> +    description: phandle to the clock connected on rtc clock line.
> +    maxItems: 1
> +
> +  clock-names:
> +    description: Names of the supplied clocks.
> +    items:
> +      - const: 32k

While it is a 32kHz clock I would prefer to use the functional name. The 
input pin on the chip is called "LPO_IN" in our schematics as well as in 
the AMPAK datasheet. In the Edge 2 schematics it is simply "LPO". 
Another name used is "EXT_LPO" as opposed to the internal LPO, which can 
be selected through boardflags3 in nvram file. Having the clock external 
is better although it seems the edge 2 does not provide the recommended 
ppm. In short I would suggest to pick one of the following names: 
lpo-in, lpo, or ext-lpo.

This affect the driver patch which is why I tend to go for consensus on 
the bindings first before posting a driver patch. With only a single 
rename it is not that much churn though.

Regards,
Arend

>   required:
>     - compatible
>     - reg

Download attachment "smime.p7s" of type "application/pkcs7-signature" (4219 bytes)