linux-kernel - Re: [PATCH] clk: imx: composite-7ulp: Use NULL instead of 0

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Znk22OwMJ7oKDLXo@linaro.org>
Date: Mon, 24 Jun 2024 12:05:28 +0300
From: Abel Vesa <abel.vesa@...aro.org>
To: "Peng Fan (OSS)" <peng.fan@....nxp.com>
Cc: abelvesa@...nel.org, mturquette@...libre.com, sboyd@...nel.org,
	shawnguo@...nel.org, s.hauer@...gutronix.de, kernel@...gutronix.de,
	festevam@...il.com, imx@...ts.linux.dev, linux-clk@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
	Peng Fan <peng.fan@....com>, kernel test robot <lkp@...el.com>
Subject: Re: [PATCH] clk: imx: composite-7ulp: Use NULL instead of 0

On 24-06-24 10:43:51, Peng Fan (OSS) wrote:
> From: Peng Fan <peng.fan@....com>
> 
> Address the sparse warnings "
> sparse warnings: (new ones prefixed by >>)
> >> drivers/clk/imx/clk-composite-7ulp.c:85:24: sparse: sparse:
> Using plain integer as NULL pointer
> "
> 
> Reported-by: kernel test robot <lkp@...el.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202406220536.JnAncjqz-lkp@intel.com/
> Signed-off-by: Peng Fan <peng.fan@....com>

Reviewed-by: Abel Vesa <abel.vesa@...aro.org>

> ---
> 
> V1:
>  Since the orignal patch is still in linux-next tree, so not add fixes tag
> 
>  drivers/clk/imx/clk-composite-7ulp.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/clk/imx/clk-composite-7ulp.c b/drivers/clk/imx/clk-composite-7ulp.c
> index db7f40b07d1a..8ed2e0ad2769 100644
> --- a/drivers/clk/imx/clk-composite-7ulp.c
> +++ b/drivers/clk/imx/clk-composite-7ulp.c
> @@ -82,7 +82,7 @@ static struct clk_hw *imx_ulp_clk_hw_composite(const char *name,
>  	val = readl(reg);
>  	if (!(val & PCG_PR_MASK)) {
>  		pr_info("PCC PR is 0 for clk:%s, bypass\n", name);
> -		return 0;
> +		return NULL;
>  	}
>  
>  	if (mux_present) {
> -- 
> 2.37.1
>