linux-kernel - Re: [PATCH v2] dmaengine: ti: k3-udma: Fix BCHAN count with UHC and HC channels

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <676c2f57-2ae7-46b6-96a4-f84f8a15d76b@ti.com>
Date: Mon, 24 Jun 2024 14:40:46 +0530
From: Jayesh Choudhary <j-choudhary@...com>
To: Jai Luthra <j-luthra@...com>, Peter Ujfalusi <peter.ujfalusi@...il.com>,
        Vinod Koul <vkoul@...nel.org>
CC: <dmaengine@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        Devarsh Thakkar <devarsht@...com>,
        Vignesh Raghavendra <vigneshr@...com>
Subject: Re: [PATCH v2] dmaengine: ti: k3-udma: Fix BCHAN count with UHC and
 HC channels

Hello Jai,

On 07/06/24 23:41, Jai Luthra wrote:
> From: Vignesh Raghavendra <vigneshr@...com>
> 
> Unlike other channel counts in CAPx registers, BCDMA BCHAN CNT doesn't
> include UHC and HC BC channels. So include them explicitly to arrive at
> total BC channel in the instance.
> 
> Fixes: 8844898028d4 ("dmaengine: ti: k3-udma: Add support for BCDMA channel TPL handling")
> Signed-off-by: Vignesh Raghavendra <vigneshr@...com>
> Signed-off-by: Jai Luthra <j-luthra@...com>

Tested audio on J722S platform on top of this patch.
McASP in J722S-EVM uses BCDMA.

Tested-by: Jayesh Choudhary <j-choudhary@...com>

> ---
> Changes in v2:
> - Add all BCHANs in a single operation
> - Update the Fixes tag to the commit adding TPL support
> - Link to v1: https://lore.kernel.org/r/20240604-bcdma_chan_cnt-v1-1-1e8932f68dca@ti.com
> ---
>   drivers/dma/ti/k3-udma.c | 4 +++-
>   1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/dma/ti/k3-udma.c b/drivers/dma/ti/k3-udma.c
> index 6400d06588a2..df507d96660b 100644
> --- a/drivers/dma/ti/k3-udma.c
> +++ b/drivers/dma/ti/k3-udma.c
> @@ -4472,7 +4472,9 @@ static int udma_get_mmrs(struct platform_device *pdev, struct udma_dev *ud)
>   		ud->rchan_cnt = UDMA_CAP2_RCHAN_CNT(cap2);
>   		break;
>   	case DMA_TYPE_BCDMA:
> -		ud->bchan_cnt = BCDMA_CAP2_BCHAN_CNT(cap2);
> +		ud->bchan_cnt = BCDMA_CAP2_BCHAN_CNT(cap2) +
> +				BCDMA_CAP3_HBCHAN_CNT(cap3) +
> +				BCDMA_CAP3_UBCHAN_CNT(cap3);
>   		ud->tchan_cnt = BCDMA_CAP2_TCHAN_CNT(cap2);
>   		ud->rchan_cnt = BCDMA_CAP2_RCHAN_CNT(cap2);
>   		ud->rflow_cnt = ud->rchan_cnt;
> 
> ---
> base-commit: d97496ca23a2d4ee80b7302849404859d9058bcd
> change-id: 20240604-bcdma_chan_cnt-bbc6c0c95259
> 
> Best regards,

Thanks,
Jayesh